Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cesql optional #1228

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Cesql optional #1228

merged 3 commits into from
Sep 28, 2023

Conversation

deissnerk
Copy link
Contributor

Fixes #

#919

Proposed Changes

  • Split the list of filter dialects into mandatory and optional dialects, where cesql is listed as OPTIONAL.

Release Note

Make clear that the support of CESQL is OPTIONAL for implementers of the subscription specification

@deissnerk
Make the implementation of CESQL OPTIONAL.
03ca17f 
Signed-off-by: Klaus Deißner <klaus.deissner@sap.com>
@deissnerk
Update formatting
2acc48b 
Signed-off-by: Klaus Deißner <klaus.deissner@sap.com>
duglin
duglin reviewed Sep 22, 2023
View reviewed changes
subscriptions/spec.md Outdated Show resolved Hide resolved
duglin
duglin reviewed Sep 22, 2023
View reviewed changes
subscriptions/spec.md Outdated Show resolved Hide resolved
@deissnerk
Address review comments
08c16b9 
Signed-off-by: Klaus Deißner <klaus.deissner@sap.com>
@duglin
Copy link
Collaborator

duglin commented Sep 23, 2023

LGTM

@duglin
Copy link
Collaborator

duglin commented Sep 28, 2023

Approved on the 9/28 call

@duglin duglin merged commit 4580f01 into cloudevents:main Sep 28, 2023
2 checks passed
@deissnerk deissnerk mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duglin duglin duglin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deissnerk @duglin