Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak URI-references and be smart with Strings #478

Merged
merged 2 commits into from
Aug 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions primer.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ This document is a working draft.
- [Design Goals](#design-goals)
- [Architecture](#architecture)
- [Versioning of Attributes](#versioning-of-attributes)
- [CloudEvent Attributes Extensions](#cloudevent-attribute-extensions)
- [CloudEvent Attributes](#cloudevent-attributes)
- [CloudEvent Attribute Extensions](#cloudevent-attribute-extensions)
- [Creating CloudEvents](#creating-cloudevents)
- [Qualifying Protocols and Encodings](#qualifying-protocols-and-encodings)
- [Proprietary Protocols and Encodings](#proprietary-protocols-and-encodings)
Expand Down Expand Up @@ -182,7 +183,7 @@ The CloudEvents specification set defines four different kinds of protocol
elements that form a layered architecture model.

1. The [base specification](spec.md) defines an abstract information model
made up of attributes (key-value pairs) and associated rules for what
made up of attributes (key-value pairs) and associated rules for what
constitutes a CloudEvent.
2. The [extensions](./spec.md#extension-context-attributes) add use-case specific
and potentially overlapping sets of extension attributes and associated
Expand All @@ -193,7 +194,7 @@ elements that form a layered architecture model.
an application protocol.
4. The transport bindings, e.g. [HTTP](http-transport-binding.md), defines
how the CloudEvent is bound to an application protocol's transport frame,
in the case of HTTP to the HTTP message. The transport binding does not
in the case of HTTP to the HTTP message. The transport binding does not
constrain how the transport frame is used, meaning that the HTTP binding
can be used with any HTTP method and with request and response messages.

Expand Down
3 changes: 3 additions & 0 deletions spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,8 @@ The following attributes are REQUIRED to be present in all CloudEvents:

- Constraints:
- REQUIRED
- MUST be a non-empty URI-reference
- An absolute URI is RECOMMENDED
- Examples
- Internet-wide unique URI with a DNS authority.
- https://github.com/cloudevents
Expand Down Expand Up @@ -363,6 +365,7 @@ on the definition of OPTIONAL.
for more information.
- Constraints:
- OPTIONAL
- If present, MUST be a non-empty URI-reference
duglin marked this conversation as resolved.
Show resolved Hide resolved

#### subject

Expand Down