Cleanup: Map and add URI in formats; re-add "Type System" heading #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Neijenhuis <christoph.neijenhuis@commercetools.de>
Signed-off-by: Christoph Neijenhuis <christoph.neijenhuis@commercetools.de>
duglin
reviewed
Aug 29, 2019
spec.md
Outdated
| @@ -155,6 +155,8 @@ These attributes, while descriptive of the event, are designed such that they | |||
| can be serialized independent of the event data. This allows for them to be | |||
| inspected at the destination without having to deserialize the event data. | |||
|
|
|||
| #### Type System | |||
There was a problem hiding this comment.
@cneijenhuis let me know when you've changed this to ### and then I'll merge
There was a problem hiding this comment.
@duglin Done :)
Signed-off-by: Christoph Neijenhuis <christoph.neijenhuis@commercetools.de>
|
@cneijenhuis thanks! Approved on the 8/29 call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup in our event formats:
MapURIAll event formats reference back to the
Type System(e.g. https://github.com/cloudevents/spec/blob/master/json-format.md#22-type-system-mapping also includes a relative link).Therefore I think it is worth adding a heading for it that can be linked back to.