This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
PI-676 updated installer to download correct php version #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -208,11 +208,15 @@ install $SOURCE_DIR/APIKey $INSTALL_DIR/bin/admin/CloudFlare/APIKey | |||
| chmod 0700 $INSTALL_DIR/bin/admin/CloudFlare/APIKey | |||
| echo "mode=simple" > $INSTALL_DIR/bin/admin/CloudFlare/APIKey.conf | |||
|
|
|||
| # Get PHP Version | |||
| CPANELSUPPORTEDPHPPATH=`ls -al $INSTALL_DIR/3rdparty/bin/php | awk '{print $11}'` | |||
| PHPVERSION=`echo $CPANELSUPPORTEDPHPPATH | rev | cut -d '/' -f 3 | rev` | |||
There was a problem hiding this comment.
What about
#!/bin/bash
IN="/usr/local/cpanel/3rdparty/php/56/bin/php"
IFS="/" && Array=($IN)
PHPVERSION=${Array[6]}
echo $PHPVERSION
http://stackoverflow.com/questions/918886/how-do-i-split-a-string-on-a-delimiter-in-bash
This rev, cut, rev logic scares me because I don't know bash and if they change the path its not clear how to fix.
There was a problem hiding this comment.
Here's a one liner which will get you the PHP version in the format you want:
PHPVERSION=/usr/local/cpanel/3rdparty/bin/php --version | head -1 | awk '{print $2}' | sed 's/.//' | cut -f 1 -d .``
There was a problem hiding this comment.
Was hoping for something a little more human readable haha :)
There was a problem hiding this comment.
@jwineman That doesn't work. In my opinion rev logic is clear enough. I can add comment to be more clear though?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.