This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
PI-873 fixed bug where when root domain was not resolved it wasn't sh… #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…own in the domains overview tab
jwineman
reviewed
Oct 26, 2016
| //The user cant provision the root domain or the resolve to record so we add them to the name list to prevent them | ||
| //from being added when we loop through the cpanel DNS records | ||
| $cf_dns_record_name_list = array($domain_name.'.', $this->partialZoneSet->getResolveToValue($domain_name)); | ||
| if ($this->partialZoneSet->getResolveToDNSRecord($cpanel_dns_record_list) !== null) { |
There was a problem hiding this comment.
Lets add a comment saying we only want the record added for full zone.
Do the tests still pass? Lets write a test ensuring the record shows up if getResolveToDNSRecord returns null.
There was a problem hiding this comment.
I'm used to running tests when pushing a commit. I think CPanel doesn't have that. I'll add that as well.
There was a problem hiding this comment.
It is set up to run them pre push but you'll need to run composer install to copy the hooks I think.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…own in the domains overview tab