Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow psr/log v3 when using composer #541

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LeoColomb
Copy link

@LeoColomb LeoColomb commented Mar 25, 2024

Alternative solution for #539.
This helps to work around the issue regarding the conflicted dependencies (specifically Psr\Log package).
This would allow installing the package on a PHP 8 server via Composer, while keeping the wp.org plugin a PHP 7.x target.

Note

This change requires the plugin to be published as a standard package on Packagist and then be released with a new tag.
https://packagist.org/packages/submit

Warning

A conditional class definition is unfortunately required to match psr/log methods signatures.
This is not very pretty, but, again, required.
b6e81b9



cc @Korben00

@LeoColomb LeoColomb mentioned this pull request Mar 25, 2024
@JulienMelissas
Copy link

JulienMelissas commented May 10, 2024

Would be great to get this reviewed/approved! We had a few hundred sites go down today updating Cloudflare via Composer thanks to this fun error 😅 (still trying to figure out why the error didn't show itself in staging)

@LeoColomb
Copy link
Author

@JulienMelissas If you are a business customer of Cloudflare, don't hesitate to open an internal ticket in their support area. If so, feel free to reference our ticket 3130507.

@LeoColomb
Copy link
Author

@aseure @jacobbednarz @william-woodhead Any possible feedback?

@tomkyser
Copy link

@aseure @jacobbednarz @william-woodhead any update? I've got a pile of duct tape getting our composer based project to work with this plugin specifically being the issue. What's holding it up?

@dev-triboo
Copy link

@aseure @jacobbednarz @william-woodhead any update?

@tomkyser tomkyser mentioned this pull request Sep 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants