Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty settings page for users with manage_options capability without administrator role #546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rvdsteege
Copy link

The WordPress admin settings page of the Cloudflare plugin is empty for users having the manage_options capability without the administrator role (as is the case with for example a custom 'Manager' role).

This PR intends to fix #544 which describes this issue, by using the same manage_options capability check for the admin menu page and the 'Cloudflare proxy':

The "Cloudflare" admin menu item requires the manage_options capability and the WordPress AJAX action cloudflare_proxy — which seems needed to load the settings page — is checking for the administrator role.

Can you take a look at this, @aseure?

@rvdsteege
Copy link
Author

@aseure it's been a month, any update on this? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty settings page for users with custom role having the manage_options capability
1 participant