Use static resource ID if "id" field is nil #638
Conversation
This is currently the case for Secondary DNS records. In the future
these records will get their own IDs, but for now, let's do this to
prevent a panic when casting a nil `interface{}` to a string.
References: DNS-10305
|
... or perhaps it's fine to ask customers to set |
|
while this may fix the generation, in reality this isn't going to work as the |
|
Makes sense, thought there'd be a catch! Let's close this, thanks Jacob! |
|
Importing/managing wouldn't work anyway for Secondary DNS records (at least as of now), but since this affects other resources too, let's not add a hack just for Secondary DNS. Especially since these are going to get IDs in the future :) |
|
sounds good! thanks |
|
if you have a way to determine when the records are associated with secondary DNS (maybe the lack of ID is enough?), we can skip them like we do with unmanaged rulesets - that can help the DX here if that is your end goal (at least for now). |
|
I'd say it's probably fine for now since we're changing this anyway. The customer in this case was trying to fetch an entire zone, which would consist of 100% Secondary records (except perhaps one override record). Let's see what they say about my suggested work-around of setting the environment variable. Thanks for your help! |
|
setting the environment variable will generate the records however they won't be able to do anything with them (no IDs to import or reference). they will also need to update every resource name to prevent collisions. note: the |
This is currently the case for Secondary DNS records. In the future these records will get their own IDs, but for now, let's do this to prevent a panic when casting a nil
interface{}to a string.References: DNS-10305