update comments

cloudflare · Apr 23, 2020 · b43f9a2 · b43f9a2
1 parent 6624bf1
commit b43f9a2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/csr/csr.go b/csr/csr.go
@@ -63,7 +63,7 @@ func (kr *KeyRequest) Size() int {
 }
 
 // Generate generates a key as specified in the request. Currently,
-// only ECDSA and RSA are supported.
+// only ECDSA and RSA and Ed25519 are supported.
 func (kr *KeyRequest) Generate() (crypto.PrivateKey, error) {
 	log.Debugf("generate key from request: algo=%s, size=%d", kr.Algo(), kr.Size())
 	switch kr.Algo() {

diff --git a/transport/kp/key_provider.go b/transport/kp/key_provider.go
@@ -213,6 +213,9 @@ func (sp *StandardProvider) Generate(algo string, size int) (err error) {
 		sp.internal.keyPEM = pem.EncodeToMemory(p)
 		sp.internal.priv = priv
 	case "ed25519":
+		if size != 256 && size != 0 {
+			return errors.New("ED25519 keys are always 256Bit")
+		}
 		_, priv, err := ed25519.GenerateKey(rand.Reader)
 
 		keyPEM, err := derhelpers.MarshalEd25519PrivateKey(priv)