Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating ed25519 keys and certs #1061

Merged
merged 39 commits into from
Jun 12, 2023

print config instead of error if test fails

ecc0574
Select commit
Loading
Failed to load commit list.
Merged

Add support for generating ed25519 keys and certs #1061

print config instead of error if test fails
ecc0574
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitGuardian / GitGuardian Security Checks failed Jun 2, 2023 in 34s

4 secrets uncovered!

4 secrets were uncovered from the scan of 39 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #1061: ed25519 👉 master
GitGuardian id Secret Commit Filename
- Generic Private Key c639e67 initca/testdata/5min-ed25519-key.pem View secret
- Generic Private Key cf7fb43 initca/testdata/5min-ed25519-key.pem View secret
- Generic Private Key ad00b62 initca/testdata/5min-ed25519-key.pem View secret
- Generic Private Key bca3df9 initca/testdata/5min-ed25519-key.pem View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!