Add BundleSign and BundleAuthSign methods to client Remote #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleSign/BundleAuthSign methods can be used like Sign/AuthSign to sign CSRs but will return the "optimal" bundle instead of only the certificate. For that to work, the caller needs to set the "bundle" parameter in the json POST data to true. This is definitely not the best way to implement this, but I think it's the least intrusive one and does not break the interface of the client.
This extends the BundleSign/BundleAuthSign API to return the root CA provided in the bundle response as well.
As it is not clear if the root CA is always returned by the CFSSL API, just make sure that the code does not panic. Also update docs for the Bundle*Sign methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BundleSign/BundleAuthSign methods can be used like Sign/AuthSign to sign
CSRs but will return the "optimal" bundle instead of only the
certificate.
For that to work, the caller needs to set the "bundle" parameter in the
json POST data to true.
This is definitely not the best way to implement this, but I think it's
the least intrusive one and does not break the interface of the client.