sidh: updates multiplication and reduction mod p434 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukevalenta
reviewed
Jun 25, 2021
lukevalenta
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Commit 8d9bbdc makes sense to me now, but I'm not sure how to effectively review the other two commits. Approving with that caveat, so please only merge if you're sufficiently confident in the changes or we have a second approver.
wbl
reviewed
Jun 30, 2021
wbl
reviewed
Jun 30, 2021
claucece
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates multiplication method described in:
https://github.com/microsoft/PQCrypto-SIDH/blob/v3.4/src/P434/AMD64/fp_x64_asm.S#L258
Updates reduction method described in:
https://github.com/microsoft/PQCrypto-SIDH/blob/v3.4/src/P434/AMD64/fp_x64_asm.S#L721-L727