Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group: adds conditional move and select to group. #353

Merged
merged 1 commit into from
Aug 1, 2022
Merged

group: adds conditional move and select to group. #353

merged 1 commit into from
Aug 1, 2022

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Jul 29, 2022

Adds conditional move and select operations for group elements and scalars.

@armfazh armfazh added the new feature New functionality or module label Jul 29, 2022
@armfazh armfazh self-assigned this Jul 29, 2022
bwesterb
bwesterb requested changes Jul 29, 2022
View reviewed changes
Copy link
Member

@bwesterb bwesterb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've added {Point,Scalar}.ConditionalSet to go-ristretto for you to use instead.

group/group.go Show resolved Hide resolved
group/group.go Show resolved Hide resolved
group/group.go Show resolved Hide resolved
group/group.go Show resolved Hide resolved
group/ristretto255.go Outdated Show resolved Hide resolved
group/ristretto255.go Show resolved Hide resolved
group/ristretto255.go Outdated Show resolved Hide resolved
@armfazh armfazh force-pushed the groupConditionals branch from 15ecfd8 to e612076 Compare July 29, 2022 18:42
@armfazh armfazh force-pushed the groupConditionals branch from e612076 to 4d0dce4 Compare July 29, 2022 21:54
@armfazh armfazh mentioned this pull request Jul 29, 2022
Merged
@armfazh armfazh requested a review from bwesterb July 29, 2022 22:03
@armfazh armfazh merged commit 10a0004 into cloudflare:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwesterb bwesterb bwesterb approved these changes

@chris-wood chris-wood Awaiting requested review from chris-wood

@cjpatton cjpatton Awaiting requested review from cjpatton

Assignees

@armfazh armfazh

Labels
new feature New functionality or module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armfazh @bwesterb