Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workers: fix typo #16220

Merged
merged 55 commits into from
Oct 24, 2024
Merged

workers: fix typo #16220

merged 55 commits into from
Oct 24, 2024

Conversation

elithrar
Copy link
Collaborator

@elithrar elithrar commented Aug 16, 2024

WIP

  • Update Get Started guide w/ new Workflow, WorkflowEntrypoint, and type params (cc @sidharthachatterjee once we have the types updated)
  • Glossary of terms (instances, steps, etc)
  • wrangler workflows commands
  • Retry API and best practices
  • Workers API guide for Workers bindings
  • Metrics and analytics (GraphQL API)
  • REST API published + linked to
  • Rules of Workflows @LuisDuarte1
  • Cron Trigger docs link to Workflows
  • Pricing
  • Limits

Later:

  • When to choose between Cron Triggers vs. Queue vs. Workflows vs. DO alarm

@elithrar elithrar self-assigned this Aug 16, 2024
@github-actions github-actions bot added the product:workflows Workflows: https://developers.cloudflare.com/workflows/ label Aug 16, 2024
@cloudflare cloudflare deleted a comment from Hominhphat23 Aug 16, 2024
Copy link

gitguardian bot commented Aug 16, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11021221 Triggered Generic High Entropy Secret 07faddc src/content/products/workflows.yaml View secret
11021221 Triggered Generic High Entropy Secret dae5204 src/content/products/workflows.yaml View secret
11021221 Triggered Generic High Entropy Secret cc09b34 astro.config.mjs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

cloudflare-workers-and-pages bot commented Aug 16, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e858bb1
Status: ✅  Deploy successful!
Preview URL: https://8e1288d3.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev

View logs

Copy link

github-actions bot commented Aug 16, 2024

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/workflows/get-started/guide/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/get-started/guide/
https://developers.cloudflare.com/workflows/build/workers-api/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/build/workers-api/
https://developers.cloudflare.com/workflows/get-started/cli-quick-start/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/get-started/cli-quick-start/
https://developers.cloudflare.com/workflows/build/rules-of-workflows/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/build/rules-of-workflows/
https://developers.cloudflare.com/workflows/observability/metrics-analytics/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/observability/metrics-analytics/
https://developers.cloudflare.com/workflows/build/trigger-workflows/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/build/trigger-workflows/
https://developers.cloudflare.com/workers/wrangler/commands/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workers/wrangler/commands/
https://developers.cloudflare.com/workflows/build/sleeping-and-retrying/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/build/sleeping-and-retrying/
https://developers.cloudflare.com/workflows/build/events-and-parameters/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/build/events-and-parameters/
https://developers.cloudflare.com/workflows/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/
https://developers.cloudflare.com/workflows/reference/pricing/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/reference/pricing/
https://developers.cloudflare.com/workflows/reference/limits/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/reference/limits/
https://developers.cloudflare.com/workflows/examples/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/examples/
https://developers.cloudflare.com/workflows/examples/automate-lifecycle-emails/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/examples/automate-lifecycle-emails/
https://developers.cloudflare.com/workflows/examples/post-process-r2/ https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev/workflows/examples/post-process-r2/

@github-actions github-actions bot added size/xl product:workers Related to Workers product and removed size/l labels Aug 26, 2024
src/content/docs/workers/wrangler/commands.mdx Outdated Show resolved Hide resolved
src/content/docs/workers/wrangler/commands.mdx Outdated Show resolved Hide resolved
src/content/docs/workers/wrangler/commands.mdx Outdated Show resolved Hide resolved
src/content/docs/workers/wrangler/commands.mdx Outdated Show resolved Hide resolved
src/content/docs/workers/wrangler/commands.mdx Outdated Show resolved Hide resolved
src/content/docs/workers/wrangler/commands.mdx Outdated Show resolved Hide resolved
src/content/docs/workers/wrangler/commands.mdx Outdated Show resolved Hide resolved
src/content/docs/workers/wrangler/commands.mdx Outdated Show resolved Hide resolved
src/content/docs/workers/wrangler/commands.mdx Outdated Show resolved Hide resolved
src/content/docs/workers/wrangler/commands.mdx Outdated Show resolved Hide resolved
src/content/docs/workflows/build/workers-api.mdx Outdated Show resolved Hide resolved
src/content/docs/workflows/build/workers-api.mdx Outdated Show resolved Hide resolved
src/content/docs/workflows/build/workers-api.mdx Outdated Show resolved Hide resolved
src/content/docs/workflows/build/workers-api.mdx Outdated Show resolved Hide resolved
src/content/docs/workflows/get-started/cli-quick-start.mdx Outdated Show resolved Hide resolved
Stops the required CI pipeline from breaking.
Not fixing it blocks merge.
elithrar and others added 4 commits October 24, 2024 06:42
Co-authored-by: Diogo Ferreira <bruxodasilva@gmail.com>
Co-authored-by: Jun Lee <junlee@cloudflare.com>
@elithrar elithrar merged commit 15720df into production Oct 24, 2024
10 of 11 checks passed
@elithrar elithrar deleted the silverlock/workflows/new branch October 24, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hyperlint-ignore product:workers Related to Workers product product:workflows Workflows: https://developers.cloudflare.com/workflows/ size/xl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants