Adds separate struct for UpdateAccessUsersSeats

This was done to abide by convention
cloudflare · Jan 30, 2024 · 6c9c526 · 6c9c526
1 parent cc42775
commit 6c9c526
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/access_seats.go b/access_seats.go
@@ -28,6 +28,13 @@ type UpdateAccessUserSeatParams struct {
 	GatewaySeat *bool  `json:"gateway_seat"`
 }
 
+// UpdateAccessUsersSeatsParams represents the update payload for multiple access seats.
+type UpdateAccessUsersSeatsParams []struct {
+	SeatUID     string `json:"seat_uid,omitempty"`
+	AccessSeat  *bool  `json:"access_seat"`
+	GatewaySeat *bool  `json:"gateway_seat"`
+}
+
 // AccessUserSeatResponse represents the response from the access user seat endpoints.
 type UpdateAccessUserSeatResponse struct {
 	Response
@@ -71,7 +78,7 @@ func (api *API) UpdateAccessUserSeat(ctx context.Context, rc *ResourceContainer,
 // UpdateAccessUsersSeats updates many Access User Seats.
 //
 // API documentation: https://developers.cloudflare.com/api/operations/zero-trust-seats-update-a-user-seat
-func (api *API) UpdateAccessUsersSeats(ctx context.Context, rc *ResourceContainer, params []UpdateAccessUserSeatParams) ([]AccessUpdateAccessUserSeatResult, error) {
+func (api *API) UpdateAccessUsersSeats(ctx context.Context, rc *ResourceContainer, params UpdateAccessUsersSeatsParams) ([]AccessUpdateAccessUserSeatResult, error) {
 	if rc.Level != AccountRouteLevel {
 		return []AccessUpdateAccessUserSeatResult{}, fmt.Errorf(errInvalidResourceContainerAccess, rc.Level)
 	}

diff --git a/access_seats_test.go b/access_seats_test.go
@@ -34,7 +34,7 @@ func TestUpdateAccessUsersSeats_MissingUID(t *testing.T) {
 	setup()
 	defer teardown()
 
-	_, err := client.UpdateAccessUsersSeats(context.Background(), testAccountRC, []UpdateAccessUserSeatParams{{GatewaySeat: BoolPtr(false), SeatUID: "seat_id"}, {SeatUID: "", AccessSeat: BoolPtr(true)}})
+	_, err := client.UpdateAccessUsersSeats(context.Background(), testAccountRC, UpdateAccessUsersSeatsParams{{GatewaySeat: BoolPtr(false), SeatUID: "seat_id"}, {SeatUID: "", AccessSeat: BoolPtr(true)}})
 	assert.EqualError(t, err, "missing required access seat UID")
 }
 
@@ -164,7 +164,7 @@ func TestUpdateAccessUsersSeats(t *testing.T) {
 		},
 	}
 
-	actual, err := client.UpdateAccessUsersSeats(context.Background(), testAccountRC, []UpdateAccessUserSeatParams{
+	actual, err := client.UpdateAccessUsersSeats(context.Background(), testAccountRC, UpdateAccessUsersSeatsParams{
 		{
 			SeatUID:     testAccessGroupSeatUID,
 			AccessSeat:  BoolPtr(false),