-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selectSignatureSchemeDC
does not account for the client's supported_algorithms
#128
Comments
YESSSS!!! Thank you for this!! |
bwesterb
pushed a commit
that referenced
this issue
Sep 7, 2022
bwesterb
pushed a commit
that referenced
this issue
Sep 8, 2022
* Define API for delegated credentials so they are fetched using the same mechanisms used to fetch certificates * Allow the usage of other keyUsage when checking for the dc extension. Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131. Add tool for generating delegated credentials. Co-authored-by: jhoyla <jhoyla@users.noreply.github.com>
bwesterb
pushed a commit
that referenced
this issue
Oct 5, 2022
* Define API for delegated credentials so they are fetched using the same mechanisms used to fetch certificates * Allow the usage of other keyUsage when checking for the dc extension. Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131. Add tool for generating delegated credentials. Co-authored-by: jhoyla <jhoyla@users.noreply.github.com>
bwesterb
pushed a commit
that referenced
this issue
Nov 1, 2022
* Define API for delegated credentials so they are fetched using the same mechanisms used to fetch certificates * Allow the usage of other keyUsage when checking for the dc extension. Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131. Add tool for generating delegated credentials. Co-authored-by: jhoyla <jhoyla@users.noreply.github.com>
bwesterb
pushed a commit
that referenced
this issue
Dec 7, 2022
* Define API for delegated credentials so they are fetched using the same mechanisms used to fetch certificates * Allow the usage of other keyUsage when checking for the dc extension. Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131. Add tool for generating delegated credentials. Co-authored-by: jhoyla <jhoyla@users.noreply.github.com>
Lekensteyn
pushed a commit
that referenced
this issue
Jan 17, 2023
* Define API for delegated credentials so they are fetched using the same mechanisms used to fetch certificates * Allow the usage of other keyUsage when checking for the dc extension. Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131. Add tool for generating delegated credentials. Co-authored-by: Jonathan Hoyland <jhoyland@cloudflare.com>
Lekensteyn
pushed a commit
that referenced
this issue
Jan 17, 2023
* Define API for delegated credentials so they are fetched using the same mechanisms used to fetch certificates * Allow the usage of other keyUsage when checking for the dc extension. Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131. Add tool for generating delegated credentials. Co-authored-by: Jonathan Hoyland <jhoyland@cloudflare.com>
Lekensteyn
pushed a commit
that referenced
this issue
Jan 19, 2023
* Define API for delegated credentials so they are fetched using the same mechanisms used to fetch certificates * Allow the usage of other keyUsage when checking for the dc extension. Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131. Add tool for generating delegated credentials. Co-authored-by: Jonathan Hoyland <jhoyland@cloudflare.com>
bwesterb
pushed a commit
that referenced
this issue
Feb 15, 2023
* Define API for delegated credentials so they are fetched using the same mechanisms used to fetch certificates * Allow the usage of other keyUsage when checking for the dc extension. Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131. Add tool for generating delegated credentials. Co-authored-by: Jonathan Hoyland <jhoyland@cloudflare.com>
bwesterb
pushed a commit
that referenced
this issue
Mar 1, 2023
* Define API for delegated credentials so they are fetched using the same mechanisms used to fetch certificates * Allow the usage of other keyUsage when checking for the dc extension. Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131. Add tool for generating delegated credentials. Co-authored-by: Jonathan Hoyland <jhoyland@cloudflare.com>
bwesterb
pushed a commit
that referenced
this issue
Mar 2, 2023
* Define API for delegated credentials so they are fetched using the same mechanisms used to fetch certificates * Allow the usage of other keyUsage when checking for the dc extension. Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131. Add tool for generating delegated credentials. Co-authored-by: Jonathan Hoyland <jhoyland@cloudflare.com>
Lekensteyn
pushed a commit
that referenced
this issue
May 8, 2023
* Define API for delegated credentials so they are fetched using the same mechanisms used to fetch certificates * Allow the usage of other keyUsage when checking for the dc extension. Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131. Add tool for generating delegated credentials. Co-authored-by: Jonathan Hoyland <jhoyland@cloudflare.com>
Lekensteyn
pushed a commit
that referenced
this issue
May 10, 2023
* Define API for delegated credentials so they are fetched using the same mechanisms used to fetch certificates * Allow the usage of other keyUsage when checking for the dc extension. Fixes issues in earlier patch, addressing #127, #128, #129, #130, and #131. Add tool for generating delegated credentials. Co-authored-by: Jonathan Hoyland <jhoyland@cloudflare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
selectSignatureSchemeDC
only checks the client'ssupportedSignatureAlgorithmsDC
field. Per the spec the selected signature scheme MUST be in both thesupportedSignatureAlgorithmsDC
andsupportedSignatureAlgorithms
fields.The text was updated successfully, but these errors were encountered: