Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CIRCL integration and dependencies. #115

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Fix CIRCL integration and dependencies. #115

merged 2 commits into from
Jul 7, 2022

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Jul 6, 2022

Changes:

  • Updated the ./cf-copy-from-circle.py script to fetch from main.
  • I added CIRCL dependencies as vendored. (Following this pattern, then it could be easier to integrate CIRCL as a vendored dep. I will investigate this option later).
  • A test script for PQ certificates was updated.

@armfazh armfazh requested review from Lekensteyn and chris-wood July 6, 2022 20:31
@armfazh armfazh mentioned this pull request Jul 6, 2022
Closed
armfazh added 2 commits July 6, 2022 15:00
@armfazh
circl: adding CIRCL v1.2.0
55b9dfa 
Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.
@armfazh
crypto/tls: updates testing of PQ certificates
3512bb6 
Certificates were hardcoded, now the PQ certificate is created
as part of the test script.
@armfazh armfazh force-pushed the armfazh/intCIRCL branch from c05acd5 to 3512bb6 Compare July 6, 2022 22:19
@Lekensteyn
Copy link
Contributor

Following this pattern, then it could be easier to integrate CIRCL as a vendored dep. I will investigate this option later.

Is circl intended for internal use only, or are there any types to be exposed to user applications? Adding it as vendored dependency could make that harder right? I forgot the motivation for using one over another, maybe because there were extra files that we were trying to remove.

A test script for PQ certificates was updated.

What was the reason for this? Did the old cert expire or something?

Lekensteyn
Lekensteyn approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@Lekensteyn Lekensteyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I saw some golang.org/x/sys/cpu imports in the vendored copies which could potentially be replaced by internal/cpu, but there are other existing instances as well, so let's keep it.

bwesterb
bwesterb approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@bwesterb bwesterb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chris-wood chris-wood merged commit 05760f7 into cf Jul 7, 2022
@chris-wood chris-wood mentioned this pull request Jul 7, 2022
Merged
@armfazh
Copy link
Contributor Author

armfazh commented Jul 7, 2022

Following this pattern, then it could be easier to integrate CIRCL as a vendored dep. I will investigate this option later.

Is circl intended for internal use only, or are there any types to be exposed to user applications? Adding it as vendored dependency could make that harder right? I forgot the motivation for using one over another, maybe because there were extra files that we were trying to remove.

You raised a good question. One way to avoid that anyone imports "circl/" while using this fork is to move it as an internal stdlib package. However, CIRCL is already a public package.

A test script for PQ certificates was updated.

What was the reason for this? Did the old cert expire or something?

Certificate was created with dilitihum from the Round 2.

@Lekensteyn Lekensteyn deleted the armfazh/intCIRCL branch July 8, 2022 10:07
bwesterb pushed a commit that referenced this pull request Jul 15, 2022
@armfazh @bwesterb
Fix CIRCL integration and dependencies. (#115)
fcf8e8a 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.
bwesterb pushed a commit that referenced this pull request Jul 15, 2022
@armfazh @bwesterb
Fix CIRCL integration and dependencies. (#115)
ee266dc 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.
bwesterb pushed a commit that referenced this pull request Aug 1, 2022
@armfazh @bwesterb
Fix CIRCL integration and dependencies. (#115)
4b64a70 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.
bwesterb pushed a commit that referenced this pull request Aug 4, 2022
@armfazh @bwesterb
Fix CIRCL integration and dependencies. (#115)
b82366e 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.
bwesterb pushed a commit that referenced this pull request Sep 7, 2022
@armfazh @bwesterb
Fix CIRCL integration and dependencies. (#115)
580551c 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.
bwesterb pushed a commit that referenced this pull request Sep 8, 2022
@armfazh @bwesterb
Fix CIRCL integration and dependencies. (#115)
2e6d729 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.
bwesterb pushed a commit that referenced this pull request Oct 5, 2022
@armfazh @bwesterb
Fix CIRCL integration and dependencies. (#115)
26694ed 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.
@armfazh armfazh mentioned this pull request Oct 19, 2022
Closed
bwesterb pushed a commit that referenced this pull request Nov 1, 2022
@armfazh @bwesterb
Fix CIRCL integration and dependencies. (#115)
4eb06c2 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.
bwesterb pushed a commit that referenced this pull request Dec 7, 2022
@armfazh @bwesterb
Fix CIRCL integration and dependencies. (#115)
08bcce7 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.
Lekensteyn pushed a commit that referenced this pull request Jan 17, 2023
@armfazh @Lekensteyn
Fix CIRCL integration and dependencies. (#115)
f4e7958 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.
Lekensteyn pushed a commit that referenced this pull request Jan 17, 2023
@armfazh @Lekensteyn
Fix CIRCL integration and dependencies. (#115)
f7eb97b 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.

 [pwu: Go 1.19: added circl to src/go/doc/comment/std.go]
Lekensteyn pushed a commit that referenced this pull request Jan 19, 2023
@armfazh @Lekensteyn
Fix CIRCL integration and dependencies. (#115)
eda22fb 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.

 [pwu: Go 1.19: added circl to src/go/doc/comment/std.go]
bwesterb pushed a commit that referenced this pull request Feb 15, 2023
@armfazh @bwesterb
Fix CIRCL integration and dependencies. (#115)
de1982e 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.

 [pwu: Go 1.19: added circl to src/go/doc/comment/std.go]
bwesterb pushed a commit that referenced this pull request Feb 15, 2023
@armfazh @bwesterb
Fix CIRCL integration and dependencies. (#115)
7ea303b 
* circl: adding CIRCL v1.2.0

Updated the ./cf-copy-from-circle.py script to fetch from main branch.
Included CIRCL's dependencies as vendored packages.

* crypto/tls: updates testing of PQ certificates

Certificates were hardcoded, now the PQ certificate is created
as part of the test script.

 [pwu: Go 1.19: added circl to src/go/doc/comment/std.go]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lekensteyn Lekensteyn Lekensteyn approved these changes

@bwesterb bwesterb bwesterb approved these changes

@chris-wood chris-wood Awaiting requested review from chris-wood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armfazh @Lekensteyn @bwesterb @chris-wood