Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: allow the usage of other keyUsage when checking for the d… #73

Merged
merged 1 commit into from
Apr 5, 2021
Merged

crypto/tls: allow the usage of other keyUsage when checking for the d… #73

merged 1 commit into from
Apr 5, 2021

Conversation

claucece
Copy link
Contributor

Should fix #72

@claucece claucece requested review from cjpatton and wbl as code owners March 31, 2021 21:09
@claucece claucece requested a review from armfazh March 31, 2021 21:10
cjpatton
cjpatton requested changes Apr 2, 2021
View reviewed changes
src/crypto/x509/x509.go Outdated Show resolved Hide resolved
lukevalenta
lukevalenta reviewed Apr 5, 2021
View reviewed changes
src/crypto/x509/x509.go Outdated Show resolved Hide resolved
lukevalenta
lukevalenta approved these changes Apr 5, 2021
View reviewed changes
Copy link

@lukevalenta lukevalenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a comment to improve readability.

@claucece claucece merged commit b0875fb into cf Apr 5, 2021
@claucece claucece deleted the cf-dc-key-usage branch April 5, 2021 14:38
cjpatton pushed a commit that referenced this pull request Jul 13, 2021
@claucece @cjpatton
crypto/tls: allow the usage of other keyUsage when checking for the d…
7f6745f 
…c extension #72 (#73)
cjpatton pushed a commit that referenced this pull request Aug 20, 2021
@claucece @cjpatton
DC-10
becfdae 
crypto/tls: Implement draft-ietf-tls-subcerts-10

crypto/tls: fixes individual testing by adding insecure verify #62

crypto/tls: define api for delegated credentials so they are fetched using the same mechanisms used to fetch certificates #67 (#69)

Refactor new API

Address comments from review

Address comments from review 2

Address comments from review 3

crypto/tls: allow the usage of other keyUsage when checking for the dc extension #72 (#73)
cjpatton pushed a commit that referenced this pull request Aug 23, 2021
@claucece @cjpatton
DC-10
5a1a0fb 
crypto/tls: Implement draft-ietf-tls-subcerts-10

crypto/tls: fixes individual testing by adding insecure verify #62

crypto/tls: define api for delegated credentials so they are fetched using the same mechanisms used to fetch certificates #67 (#69)

Refactor new API

Address comments from review

Address comments from review 2

Address comments from review 3

crypto/tls: allow the usage of other keyUsage when checking for the dc extension #72 (#73)
cjpatton pushed a commit that referenced this pull request Aug 23, 2021
@claucece @cjpatton
DC-10
2944acb 
crypto/tls: Implement draft-ietf-tls-subcerts-10

crypto/tls: fixes individual testing by adding insecure verify #62

crypto/tls: define api for delegated credentials so they are fetched using the same mechanisms used to fetch certificates #67 (#69)

Refactor new API

Address comments from review

Address comments from review 2

Address comments from review 3

crypto/tls: allow the usage of other keyUsage when checking for the dc extension #72 (#73)
cjpatton pushed a commit that referenced this pull request Aug 23, 2021
@claucece @cjpatton
DC-10
92d11f7 
crypto/tls: Implement draft-ietf-tls-subcerts-10

crypto/tls: fixes individual testing by adding insecure verify #62

crypto/tls: define api for delegated credentials so they are fetched using the same mechanisms used to fetch certificates #67 (#69)

Refactor new API

Address comments from review

Address comments from review 2

Address comments from review 3

crypto/tls: allow the usage of other keyUsage when checking for the dc extension #72 (#73)
cjpatton pushed a commit that referenced this pull request Aug 23, 2021
@claucece @cjpatton
DC-10
e153ce3 
crypto/tls: Implement draft-ietf-tls-subcerts-10

crypto/tls: fixes individual testing by adding insecure verify #62

crypto/tls: define api for delegated credentials so they are fetched using the same mechanisms used to fetch certificates #67 (#69)

Refactor new API

Address comments from review

Address comments from review 2

Address comments from review 3

crypto/tls: allow the usage of other keyUsage when checking for the dc extension #72 (#73)
cjpatton pushed a commit that referenced this pull request Aug 23, 2021
@claucece @cjpatton
DC-10
fecfb90 
crypto/tls: Implement draft-ietf-tls-subcerts-10

crypto/tls: fixes individual testing by adding insecure verify #62

crypto/tls: define api for delegated credentials so they are fetched using the same mechanisms used to fetch certificates #67 (#69)

Refactor new API

Address comments from review

Address comments from review 2

Address comments from review 3

crypto/tls: allow the usage of other keyUsage when checking for the dc extension #72 (#73)
cjpatton pushed a commit that referenced this pull request Aug 23, 2021
@claucece @cjpatton
DC-10
a296e3e 
crypto/tls: Implement draft-ietf-tls-subcerts-10

crypto/tls: fixes individual testing by adding insecure verify #62

crypto/tls: define api for delegated credentials so they are fetched using the same mechanisms used to fetch certificates #67 (#69)

Refactor new API

Address comments from review

Address comments from review 2

Address comments from review 3

crypto/tls: allow the usage of other keyUsage when checking for the dc extension #72 (#73)
cjpatton pushed a commit that referenced this pull request Aug 23, 2021
@claucece @cjpatton
DC-10
ee7e5a7 
crypto/tls: Implement draft-ietf-tls-subcerts-10

crypto/tls: fixes individual testing by adding insecure verify #62

crypto/tls: define api for delegated credentials so they are fetched using the same mechanisms used to fetch certificates #67 (#69)

Refactor new API

Address comments from review

Address comments from review 2

Address comments from review 3

crypto/tls: allow the usage of other keyUsage when checking for the dc extension #72 (#73)
Lekensteyn pushed a commit that referenced this pull request Sep 24, 2021
@claucece @Lekensteyn
crypto/tls: allow the usage of other keyUsage when checking for the d…
1a56f27 
…c extension #72 (#73)
Lekensteyn pushed a commit that referenced this pull request Sep 24, 2021
@claucece @Lekensteyn
crypto/tls: allow the usage of other keyUsage when checking for the d…
a3dddf1 
…c extension #72 (#73)
Lekensteyn pushed a commit that referenced this pull request Jan 11, 2022
@claucece @Lekensteyn
crypto/tls: allow the usage of other keyUsage when checking for the d…
7a564e6 
…c extension #72 (#73)
Lekensteyn pushed a commit that referenced this pull request Jan 14, 2022
@claucece @Lekensteyn
crypto/tls: allow the usage of other keyUsage when checking for the d…
08d9645 
…c extension #72 (#73)
@Lekensteyn Lekensteyn mentioned this pull request Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukevalenta lukevalenta lukevalenta approved these changes

@cjpatton cjpatton cjpatton approved these changes

@wbl wbl Awaiting requested review from wbl

@armfazh armfazh Awaiting requested review from armfazh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crypto/tls: keyUsage tests exclusively for DigitalSignature flag
3 participants
@claucece @cjpatton @lukevalenta