Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetcher.fetch() internal url #724

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix fetcher.fetch() internal url #724

merged 1 commit into from
Oct 25, 2023

Conversation

RamIdeas
Copy link
Contributor

This PR fixes #721

Now the origin passed to Fetcher.fetch(url) is what is seen inside the worker in request.url

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

⚠️ No Changeset found

Latest commit: e5ebfbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@RamIdeas RamIdeas changed the base branch from master to tre October 25, 2023 11:32
@RamIdeas RamIdeas closed this Oct 25, 2023
@RamIdeas RamIdeas reopened this Oct 25, 2023
@mrbbot mrbbot merged commit e92af0d into tre Oct 25, 2023
@mrbbot mrbbot deleted the fix-fetcher-fetch-url branch October 25, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbbot mrbbot mrbbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getWorker().fetch does not preserve origin
2 participants
@RamIdeas @mrbbot