Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Chart fails when cert-manager runs in different namespace #45

Closed
nadenf opened this issue Oct 27, 2021 · 0 comments · Fixed by #76
Closed

Helm Chart fails when cert-manager runs in different namespace #45

nadenf opened this issue Oct 27, 2021 · 0 comments · Fixed by #76
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
v0.7.0

Comments

@nadenf
Copy link

nadenf commented Oct 27, 2021

If you look at this file:
https://github.com/cloudflare/origin-ca-issuer/blob/trunk/deploy/charts/origin-ca-issuer/templates/issuer-rolebinding.yaml

It assumes that cert-manager is running in the cert-manager namespace which isn't always the case.
@terinjokes terinjokes mentioned this issue Dec 7, 2021
Closed
@terinjokes terinjokes added this to the v0.7.0 milestone Dec 7, 2021
@terinjokes terinjokes added bug Something isn't working good first issue Good for newcomers labels Dec 7, 2021
@sidineyc sidineyc mentioned this issue May 25, 2022
Closed
terinjokes added a commit that referenced this issue Nov 23, 2022
@terinjokes
fix(helm): rolebinding should use templated values
df38237 
The ClusterRoleBinding created for the cert-manager service account did
not correctly use the templated values for the subject reference to the
service account.

Fixes #45
terinjokes added a commit that referenced this issue Nov 23, 2022
@terinjokes
fix(helm): rolebinding should use templated values
74c11e5 
The ClusterRoleBinding created for the cert-manager service account did
not correctly use the templated values for the subject reference to the
service account.

Fixes #45
terinjokes added a commit that referenced this issue Nov 23, 2022
@terinjokes
fix(helm): rolebinding should use templated values
b9d4355 
The ClusterRoleBinding created for the cert-manager service account did
not correctly use the templated values for the subject reference to the
service account.

Fixes #45
@terinjokes terinjokes mentioned this issue Nov 23, 2022
Merged
terinjokes added a commit that referenced this issue May 2, 2023
@terinjokes
fix(helm): rolebinding should use templated values
f2e8638 
The ClusterRoleBinding created for the cert-manager service account did
not correctly use the templated values for the subject reference to the
service account.

Fixes #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

fix(helm): rolebinding should use templated values cloudflare/origin-ca-issuer
2 participants
@terinjokes @nadenf