Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OriginRSA and OriginECC are flipped? #72

Closed
ckwalsh opened this issue Nov 2, 2022 · 1 comment · Fixed by #75
Closed

OriginRSA and OriginECC are flipped? #72

ckwalsh opened this issue Nov 2, 2022 · 1 comment · Fixed by #75

Comments

@ckwalsh
Copy link

ckwalsh commented Nov 2, 2022

Take a look at

origin-ca-issuer/pkgs/provisioners/origin.go

Lines 108 to 111 in 39d567a

case v1.RequestTypeOriginECC:
reqType = "origin-rsa"
case v1.RequestTypeOriginRSA:
reqType = "origin-ecc"

I just installed origin-ca-issuer (it works great!), but I noticed I got a SHA256-RSA signature when using the OriginIssuer example from the README, which sets requestType: OriginECC.

Conversely, when I updated it to requestType: OriginRSA and forced a certificate to be reissued, I got a ECDSA-SHA256 signature.
@terinjokes
Copy link
Contributor

Well, that's ackward. This area was refectored as part of open sourcing, so I'll have to check pre-history to understand what went wrong. I suspect a bad merge somehow happened.

terinjokes added a commit that referenced this issue Nov 22, 2022
@terinjokes
fix(provisioners): request correct signing type
f0cbc24 
The requested certificate type was backwards, so requesting an RSA
signature resulted in an ECC signature from the Origin CA API and
vice-versa.

This changeset corrects the requested signature type, and adds tests to
verify the provisioner's behaviors.

Fixes #72
@terinjokes terinjokes mentioned this issue Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(provisioners): request correct signing type cloudflare/origin-ca-issuer
2 participants
@ckwalsh @terinjokes