fix(cfapi): requeue after DB error #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pims
approved these changes
May 17, 2024
cbroglie
reviewed
May 17, 2024
terinjokes
force-pushed
the
terin/apierror
branch
3 times, most recently
from
241b0f9
to
3ab8e94
Compare
The Origin CA API occasionally returns error code 1100 signaling a failure to write the certificate to the database. This reconciler intepreted this error as a permament failure, despite no local issues. This changeset detects this error code and requeues the CertificateRequest with controller-runtime's default backoff behavior. Fixes: #115 Fixes: #116
cbroglie
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Origin CA API occasionally returns error code 1100 signaling a failure to write the certificate to the database. This reconciler intepreted this error as a permament failure, despite no local issues.
This changeset detects this error code and requeues the CertificateRequest with controller-runtime's default backoff behavior.
Fixes: #115
Fixes: #116