Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comment warnings #1028

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Improve comment warnings #1028

merged 1 commit into from
Jul 11, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.61.2-5-gda020e3
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.95m ± 3%   39.15m ± 1%  -2.00% (p=0.001 n=10)
CheckRules-4     8.511 ± 2%    8.536 ± 2%       ~ (p=0.393 n=10)
geomean         583.1m        578.1m       -0.86%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.39Mi ± 0%   27.39Mi ± 0%       ~ (p=0.218 n=10)
CheckRules-4    935.1Mi ± 0%   936.7Mi ± 0%  +0.16% (p=0.023 n=10)
geomean         160.0Mi        160.2Mi       +0.08%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.6k ± 0%   131.6k ± 0%       ~ (p=0.075 n=10)
CheckRules-4    13.92M ± 0%   13.92M ± 0%       ~ (p=0.436 n=10)
geomean         1.353M        1.353M       +0.01%

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.87640% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.59%. Comparing base (f4eaf91) to head (da020e3).

Files Patch % Lines
internal/checks/promql_series.go 98.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
- Coverage   94.59%   94.59%   -0.01%     
==========================================
  Files          96       96              
  Lines        9792     9797       +5     
==========================================
+ Hits         9263     9267       +4     
- Misses        374      375       +1     
  Partials      155      155              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 19dbe12 into main Jul 11, 2024
20 checks passed
@prymitive prymitive deleted the comments branch July 11, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants