make matching a strict subset of labels #190
Conversation
|
closes #158 |
|
@eiais it looks like this caused the build to fail. |
|
@kisom Yeah, there's a test in core_test that needs fixing. Also this could be a breaking change for some users I think. Is that something you would be concerned with merging? |
keycache/keycache.go
Outdated
| for _, label := range labels { | ||
| if label == validLabel { | ||
| return true | ||
| //Given an asset usage label must be a superset |
There was a problem hiding this comment.
Though this code predates some of our best practices (and the comment does match the style of other comments), it should follow standard Go practices now; e.g.
// Given an asset, usage label must be a superset.
Signed-off-by: Kyle Spiers <kyle@spiers.me>
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 35.57% 35.62% +0.05%
==========================================
Files 21 21
Lines 4964 4968 +4
==========================================
+ Hits 1766 1770 +4
Misses 2963 2963
Partials 235 235
Continue to review full report at Codecov.
|
|
@kisom Should be good to go now. |
|
@eiais I'm going to have to do an audit of some our usage of RO this week to figure out if this will negatively impact anything, I'll keep you updated. |
|
@kisom Any update? |
|
Should I close this PR? |
|
@grittygrease Can I get an update on this? |
Signed-off-by: Kyle Spiers kyle@spiers.me