Merge pull request #4511 from Cyb3r-Jak3/avoid-duplicate-list-item-cr…

…eation Don't set items for lists when not needed
cloudflare · Nov 13, 2024 · c03faeb · c03faeb
2 parents a926ff0 + 2c128b7
commit c03faeb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/.changelog/4511.txt b/.changelog/4511.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resource/cloudflare_list: Don't read list items if there are none configured
+```
diff --git a/internal/framework/service/list/resource.go b/internal/framework/service/list/resource.go
@@ -99,15 +99,17 @@ func (r *ListResource) Read(ctx context.Context, req resource.ReadRequest, resp
 	state.Description = types.StringValue(list.Description)
 	state.Kind = types.StringValue(list.Kind)
 
-	items, err := r.client.V1.ListListItems(ctx, cloudflare.AccountIdentifier(state.AccountID.ValueString()), cloudflare.ListListItemsParams{
-		ID: state.ID.ValueString(),
-	})
-	if err != nil {
-		resp.Diagnostics.AddError("Error reading List Items", err.Error())
-		return
-	}
+	if len(state.Items) > 0 {
+		items, err := r.client.V1.ListListItems(ctx, cloudflare.AccountIdentifier(state.AccountID.ValueString()), cloudflare.ListListItemsParams{
+			ID: state.ID.ValueString(),
+		})
+		if err != nil {
+			resp.Diagnostics.AddError("Error reading List Items", err.Error())
+			return
+		}
 
-	state.Items = buildListItemModels(items)
+		state.Items = buildListItemModels(items)
+	}
 
 	diags = resp.State.Set(ctx, &state)
 	resp.Diagnostics.Append(diags...)