Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/cloudflare_teams_account: Add support for virtual_ip #3321

Merged
merged 8 commits into from
Jun 6, 2024
Merged

resource/cloudflare_teams_account: Add support for virtual_ip #3321

merged 8 commits into from
Jun 6, 2024

Conversation

josip-stanic
Copy link
Contributor

@josip-stanic josip-stanic commented May 22, 2024 •
edited
Loading

Adds support for virtual_ip in the cloudflare_teams_account resource. Depends on cloudflare/cloudflare-go#2126 (v0.97.0).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2024 •
edited
Loading

changelog detected ✅

@josip-stanic josip-stanic changed the title Feature: Add support for virtual_ip in resource_cloudflare_teams_account resource/cloudflare_teams_account: Add support for virtual_ip May 24, 2024
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTeamsAccounts_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTeamsAccounts_ConfigurationBasic
--- PASS: TestAccCloudflareTeamsAccounts_ConfigurationBasic (10.95s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	12.149s

@jacobbednarz jacobbednarz merged commit c0a2b85 into cloudflare:master Jun 6, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.35.0 milestone Jun 6, 2024
github-actions bot pushed a commit that referenced this pull request Jun 6, 2024
Update CHANGELOG.md for #3321
dced1f5
@josip-stanic josip-stanic deleted the feat/UseZtVirtualIP-CGNAT branch June 6, 2024 05:44
josip-stanic pushed a commit to josip-stanic/terraform-provider-cloudflare that referenced this pull request Jun 10, 2024
@josip-stanic
Update CHANGELOG.md for cloudflare#3321
2aed255
@TylerStanish TylerStanish mentioned this pull request Jun 10, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v4.35.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@josip-stanic @jacobbednarz