Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content scanning expression resource #4734

Merged

Conversation

mrusso19
Copy link
Contributor

@mrusso19 mrusso19 commented Dec 9, 2024

This PR creates a new resource for managing custom scan expression via the Content Scanning API.

Testing it requires using cloudflare-go unreleased changes.

Tests

TEST=./internal/framework/service/content_scanning_expression/ TESTARGS='-run "^TestAccCloudflareContentScanningExpression_Basic" -count 1' make testacc
TF_ACC=1 go test ./internal/framework/service/content_scanning_expression/ -v -run "^TestAccCloudflareContentScanningExpression_Basic" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareContentScanningExpression_Basic
--- PASS: TestAccCloudflareContentScanningExpression_Basic (6.23s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/content_scanning_expression      6.241s

Copy link
Contributor

github-actions bot commented Dec 9, 2024

changelog detected ✅

@jacobbednarz
Copy link
Member

jacobbednarz commented Dec 26, 2024

acceptance tests all passing

TEST=./internal/framework/service/content_scanning_expression/ TESTARGS='-run "^TestAccCloudflareContentScanningExpression_" -count 1' make testacc
TF_ACC=1 go test ./internal/framework/service/content_scanning_expression/ -v -run "^TestAccCloudflareContentScanningExpression_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareContentScanningExpression_Basic
--- PASS: TestAccCloudflareContentScanningExpression_Basic (5.55s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/content_scanning_expression      5.922s

@jacobbednarz jacobbednarz merged commit 1ef0bed into cloudflare:master Dec 26, 2024
7 checks passed
@github-actions github-actions bot added this to the v4.49.0 milestone Dec 26, 2024
Copy link
Contributor

This functionality has been released in v4.49.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants