Reapply illegal invocation error message patch

cloudflare · Jul 12, 2024 · 256bb63 · 256bb63
1 parent 5f6982d
commit 256bb63
Show file tree

Hide file tree

Showing 20 changed files with 21 additions and 20 deletions.
diff --git a/WORKSPACE b/WORKSPACE
@@ -484,6 +484,7 @@ http_archive(
         "//:patches/v8/0016-Rename-V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE-V8_COMPR.patch",
         "//:patches/v8/0017-Revert-TracedReference-deref-API-removal.patch",
         "//:patches/v8/0018-Revert-heap-Add-masm-specific-unwinding-annotations-.patch",
+        "//:patches/v8/0019-Update-illegal-invocation-error-message-in-v8.patch",
     ],
     integrity = "sha256-TKEA0q6AADxlgXHIprTaw/CgQDBB6Vhug3JWlXmFKrg=",
     strip_prefix = "v8-12.7.224.13",

diff --git a/patches/v8/0001-Allow-manually-setting-ValueDeserializer-format-vers.patch b/patches/v8/0001-Allow-manually-setting-ValueDeserializer-format-vers.patch
@@ -1,4 +1,4 @@
-From 26d127799ac5f672c8d06bd5b6cd1ae061368528 Mon Sep 17 00:00:00 2001
+From 9c1e267f52dfe7cd9264680452068ede59805a52 Mon Sep 17 00:00:00 2001
 From: Alex Robinson <arobinson@cloudflare.com>
 Date: Wed, 2 Mar 2022 15:58:04 -0600
 Subject: Allow manually setting ValueDeserializer format version

diff --git a/patches/v8/0002-Allow-manually-setting-ValueSerializer-format-versio.patch b/patches/v8/0002-Allow-manually-setting-ValueSerializer-format-versio.patch
@@ -1,4 +1,4 @@
-From 304113bda2b144d39410df773ebcb6211f676e4b Mon Sep 17 00:00:00 2001
+From 3253a1204a2c8403ae3d6ed74099275d0ade9541 Mon Sep 17 00:00:00 2001
 From: James M Snell <jasnell@gmail.com>
 Date: Wed, 16 Mar 2022 08:59:21 -0700
 Subject: Allow manually setting ValueSerializer format version

diff --git a/patches/v8/0003-Add-ArrayBuffer-MaybeNew.patch b/patches/v8/0003-Add-ArrayBuffer-MaybeNew.patch
@@ -1,4 +1,4 @@
-From 04460388a865432042cf6261f3b2d3c6a3c78020 Mon Sep 17 00:00:00 2001
+From 1d861f69dcf5d40faf94b2c844f96432a190b4f2 Mon Sep 17 00:00:00 2001
 From: Kenton Varda <kenton@cloudflare.com>
 Date: Fri, 16 Sep 2022 21:41:45 -0500
 Subject: Add `ArrayBuffer::MaybeNew()`.

diff --git a/patches/v8/0004-Allow-Windows-builds-under-Bazel.patch b/patches/v8/0004-Allow-Windows-builds-under-Bazel.patch
@@ -1,4 +1,4 @@
-From a32201984aec7db461f5ffd0ce36f79788f1e11b Mon Sep 17 00:00:00 2001
+From 955b1cda5189cc04f6a94e4b65c512acd0ec9219 Mon Sep 17 00:00:00 2001
 From: Brendan Coll <bcoll@cloudflare.com>
 Date: Thu, 16 Mar 2023 11:56:10 +0000
 Subject: Allow Windows builds under Bazel

diff --git a/patches/v8/0005-Disable-bazel-whole-archive-build.patch b/patches/v8/0005-Disable-bazel-whole-archive-build.patch
@@ -1,4 +1,4 @@
-From 937488b3a4822ff90b1fd4d6f8ecefe2ab6aefd2 Mon Sep 17 00:00:00 2001
+From 67f680b997ee83e78d7b496640ba500c8ead5311 Mon Sep 17 00:00:00 2001
 From: Felix Hanau <felix@cloudflare.com>
 Date: Tue, 11 Apr 2023 14:41:31 -0400
 Subject: Disable bazel whole-archive build

diff --git a/patches/v8/0006-Speed-up-V8-bazel-build-by-always-using-target-cfg.patch b/patches/v8/0006-Speed-up-V8-bazel-build-by-always-using-target-cfg.patch
@@ -1,4 +1,4 @@
-From 68e5b9583717b91f2e028bf2efd242ef260341fe Mon Sep 17 00:00:00 2001
+From 278a7759097eecc930167cad67457aac7dadbb02 Mon Sep 17 00:00:00 2001
 From: Felix Hanau <felix@cloudflare.com>
 Date: Wed, 7 Jun 2023 21:40:54 -0400
 Subject: Speed up V8 bazel build by always using target cfg

diff --git a/patches/v8/0007-Implement-Promise-Context-Tagging.patch b/patches/v8/0007-Implement-Promise-Context-Tagging.patch
@@ -1,4 +1,4 @@
-From 1ef8dc77b18a00bb5cb9684d0b44380e29c7b00a Mon Sep 17 00:00:00 2001
+From ee11b275f3fd56682e04868149ef26c1a9f94e3d Mon Sep 17 00:00:00 2001
 From: James M Snell <jasnell@gmail.com>
 Date: Thu, 22 Jun 2023 15:29:26 -0700
 Subject: Implement Promise Context Tagging

diff --git a/patches/v8/0008-Enable-V8-shared-linkage.patch b/patches/v8/0008-Enable-V8-shared-linkage.patch
@@ -1,4 +1,4 @@
-From 372957fc7fc2b0bcc196e6ac8a19b7a1a00cfe7b Mon Sep 17 00:00:00 2001
+From c14d05513814dc04b3c8e32facf812358e882df5 Mon Sep 17 00:00:00 2001
 From: Felix Hanau <felix@cloudflare.com>
 Date: Sun, 9 Jul 2023 18:46:20 -0400
 Subject: Enable V8 shared linkage

diff --git a/patches/v8/0009-Randomize-the-initial-ExecutionContextId-used-by-the.patch b/patches/v8/0009-Randomize-the-initial-ExecutionContextId-used-by-the.patch
@@ -1,4 +1,4 @@
-From 81e175a44db635de0165ffc1f3f480dce05e5ef0 Mon Sep 17 00:00:00 2001
+From eecddb628a5c43b5cc5f19a3311c378dcece1627 Mon Sep 17 00:00:00 2001
 From: Orion Hodson <orion@cloudflare.com>
 Date: Wed, 13 Sep 2023 15:38:15 +0100
 Subject: Randomize the initial ExecutionContextId used by the inspector

diff --git a/patches/v8/0010-Always-enable-continuation-preserved-data-in-the-bui.patch b/patches/v8/0010-Always-enable-continuation-preserved-data-in-the-bui.patch
@@ -1,4 +1,4 @@
-From 67c035ec42816c9ac345a9a80304294ac4fe21ab Mon Sep 17 00:00:00 2001
+From 3088caad9c85b24f245b47ada63cb56ed6b78b0f Mon Sep 17 00:00:00 2001
 From: James M Snell <jasnell@gmail.com>
 Date: Thu, 18 Jan 2024 10:19:14 -0800
 Subject: Always enable continuation preserved data in the build

diff --git a/patches/v8/0011-increase-visibility-of-virtual-method.patch b/patches/v8/0011-increase-visibility-of-virtual-method.patch
@@ -1,4 +1,4 @@
-From de8ec2c160f304af057d9182ea034149d29960b1 Mon Sep 17 00:00:00 2001
+From 650cb04c30fd0707f7443988cd2c97c778bec7d8 Mon Sep 17 00:00:00 2001
 From: Mike Aizatsky <maizatskyi@cloudflare.com>
 Date: Tue, 6 Feb 2024 12:55:07 -0800
 Subject: increase visibility of virtual method

diff --git a/patches/v8/0012-Add-ValueSerializer-SetTreatFunctionsAsHostObjects.patch b/patches/v8/0012-Add-ValueSerializer-SetTreatFunctionsAsHostObjects.patch
@@ -1,4 +1,4 @@
-From dcc0162a1a334f3971aa4ec325754c2b8df129e3 Mon Sep 17 00:00:00 2001
+From b413a9f57e487688c37ef3e92632292571a59596 Mon Sep 17 00:00:00 2001
 From: Kenton Varda <kenton@cloudflare.com>
 Date: Sat, 2 Mar 2024 09:00:18 -0600
 Subject: Add ValueSerializer::SetTreatFunctionsAsHostObjects().

diff --git a/patches/v8/0013-Set-torque-generator-path-to-external-v8.-This-allow.patch b/patches/v8/0013-Set-torque-generator-path-to-external-v8.-This-allow.patch
@@ -1,4 +1,4 @@
-From 440f6a517f294ecd6f7489c4b76f8e2ceff7ba30 Mon Sep 17 00:00:00 2001
+From 7e7ea0724d97fe80eb39b3a46708cebfe3a517b9 Mon Sep 17 00:00:00 2001
 From: Garrett Gu <garrett@cloudflare.com>
 Date: Wed, 10 Apr 2024 14:31:33 -0500
 Subject: Set torque generator path to external/v8. This allows bazel to find

diff --git a/patches/v8/0014-Modify-where-to-look-for-fp16-dependency.-This-depen.patch b/patches/v8/0014-Modify-where-to-look-for-fp16-dependency.-This-depen.patch
@@ -1,4 +1,4 @@
-From 462fda3cbba1d6fc36e7594266cc79e896f51fc9 Mon Sep 17 00:00:00 2001
+From 9bec243b8da206665490e5fcd8dc8059339dc039 Mon Sep 17 00:00:00 2001
 From: Garrett Gu <garrett@cloudflare.com>
 Date: Mon, 22 Apr 2024 10:10:21 -0500
 Subject: Modify where to look for fp16 dependency. This dependency is normally

diff --git a/patches/v8/0015-Expose-v8-Symbol-GetDispose.patch b/patches/v8/0015-Expose-v8-Symbol-GetDispose.patch
@@ -1,4 +1,4 @@
-From 7ca2f4f9b8f240d926f944844b7178b21145a6eb Mon Sep 17 00:00:00 2001
+From 5563f8c04c3cdf380f92312873bc487c39e28d7b Mon Sep 17 00:00:00 2001
 From: Jon Phillips <jphillips@cloudflare.com>
 Date: Tue, 30 Apr 2024 00:06:33 +0100
 Subject: Expose v8::Symbol::GetDispose().

diff --git a/patches/v8/0016-Rename-V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE-V8_COMPR.patch b/patches/v8/0016-Rename-V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE-V8_COMPR.patch
@@ -1,4 +1,4 @@
-From cbc1f050a53ad37c257c580a0cc91f54824c402c Mon Sep 17 00:00:00 2001
+From abd3b18a0feac502ac3724818483e222767b83e0 Mon Sep 17 00:00:00 2001
 From: Jon Phillips <jphillips@cloudflare.com>
 Date: Thu, 9 May 2024 23:36:43 +0100
 Subject: Rename V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE ->

diff --git a/patches/v8/0017-Revert-TracedReference-deref-API-removal.patch b/patches/v8/0017-Revert-TracedReference-deref-API-removal.patch
@@ -1,4 +1,4 @@
-From 4f885dbe5397621017b1d2ee46560e2dd768a02f Mon Sep 17 00:00:00 2001
+From 97f6fcebc3b908c0cbc918bcf47591fd18e2cba0 Mon Sep 17 00:00:00 2001
 From: Harris Hancock <harris@cloudflare.com>
 Date: Fri, 28 Jun 2024 14:19:25 +0100
 Subject: Revert TracedReference deref API removal

diff --git a/patches/v8/0018-Revert-heap-Add-masm-specific-unwinding-annotations-.patch b/patches/v8/0018-Revert-heap-Add-masm-specific-unwinding-annotations-.patch
@@ -1,4 +1,4 @@
-From 04b1867f055a9d5034a7cbbfc46eaf730c88e275 Mon Sep 17 00:00:00 2001
+From 2241358ba2085c5a5f9d8c74ba41171d4dc0d4da Mon Sep 17 00:00:00 2001
 From: Harris Hancock <harris@cloudflare.com>
 Date: Wed, 3 Jul 2024 15:46:43 +0100
 Subject: Revert "heap: Add masm-specific unwinding annotations to GC

diff --git a/...egal-invocation-error-message-in-v8.patch → ...egal-invocation-error-message-in-v8.patch b/...egal-invocation-error-message-in-v8.patch → ...egal-invocation-error-message-in-v8.patch
@@ -1,11 +1,11 @@
-From ce2599232e1fbe059e64df5a4d6feb8fa5894af6 Mon Sep 17 00:00:00 2001
+From bd3333d53de62140f33b4b8ba8656f2162da2c47 Mon Sep 17 00:00:00 2001
 From: James M Snell <jasnell@gmail.com>
 Date: Tue, 9 Jul 2024 08:37:05 -0700
 Subject: Update illegal invocation error message in v8
 
 
 diff --git a/src/common/message-template.h b/src/common/message-template.h
-index 56fd240ac5145b26b43edf9e1c1d24b5f44c1031..f240b3b70fb97e8786dc2f3c665481125defb327 100644
+index 5c7ffea18f6dd9976735213fff2e117225350f26..22e3f17402390dcdc723e2a9d4a56e048567f20b 100644
 --- a/src/common/message-template.h
 +++ b/src/common/message-template.h
 @@ -112,7 +112,9 @@ namespace internal {