Skip to content

Commit

Permalink
Move node-internal:inspect into node-internal:util
Browse files Browse the repository at this point in the history
  • Loading branch information
mrbbot committed Oct 18, 2023
1 parent cb6f3d7 commit 4daaf83
Show file tree
Hide file tree
Showing 10 changed files with 253 additions and 283 deletions.
84 changes: 0 additions & 84 deletions src/node/internal/inspect.d.ts

This file was deleted.

6 changes: 3 additions & 3 deletions src/node/internal/internal_buffer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import {
validateString,
} from 'node-internal:validators';

import internalInspect from 'node-internal:inspect';
import internalUtil from 'node-internal:util';
import {
InspectOptionsStylized,
inspect as utilInspect,
Expand Down Expand Up @@ -600,9 +600,9 @@ Buffer.prototype.inspect = function inspect(_recurseTimes: number, ctx: InspectO
// Inspect special properties as well, if possible.
if (ctx) {
let extras = false;
const filter = ctx.showHidden ? internalInspect.ALL_PROPERTIES : internalInspect.ONLY_ENUMERABLE;
const filter = ctx.showHidden ? internalUtil.ALL_PROPERTIES : internalUtil.ONLY_ENUMERABLE;
const obj: Record<PropertyKey, unknown> = { __proto__: null };
internalInspect.getOwnNonIndexProperties(this, filter).forEach(
internalUtil.getOwnNonIndexProperties(this, filter).forEach(
(key) => {
extras = true;
obj[key] = this[key];
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/internal_inspect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
/* todo: the following is adopted code, enabling linting one day */
/* eslint-disable */

import internal from "node-internal:inspect";
import internal from "node-internal:util";

import { Buffer } from "node-internal:internal_buffer";
import {
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/internal_types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

import internal from "node-internal:inspect";
import internal from "node-internal:util";

export function isCryptoKey(value: unknown): boolean {
return value instanceof CryptoKey;
Expand Down
86 changes: 86 additions & 0 deletions src/node/internal/util.d.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// Copyright (c) 2017-2022 Cloudflare, Inc.
// Licensed under the Apache 2.0 license found in the LICENSE file or at:
// https://opensource.org/licenses/Apache-2.0

/* eslint-disable @typescript-eslint/no-explicit-any */
/* eslint-disable @typescript-eslint/ban-types */

export abstract class MIMEType {
public constructor(input: string);
public type: string;
Expand All @@ -21,3 +25,85 @@ export abstract class MIMEParams {
public keys(): Iterable<string>;
public values(): Iterable<string>;
}

export const kResourceTypeInspect: unique symbol;

export const ALL_PROPERTIES: 0;
export const ONLY_ENUMERABLE: 1;
export function getOwnNonIndexProperties(value: unknown, filter: typeof ALL_PROPERTIES | typeof ONLY_ENUMERABLE): PropertyKey[];

export const kPending: 0;
export const kFulfilled: 1;
export const kRejected: 2;
export interface PromiseDetails {
state: typeof kPending | typeof kFulfilled | typeof kRejected;
result: unknown;
}
export function getPromiseDetails(value: unknown): PromiseDetails | undefined;

export interface ProxyDetails {
target: unknown;
handler: unknown;
}
export function getProxyDetails(value: unknown): ProxyDetails | undefined;

export interface PreviewedEntries {
entries: unknown[];
isKeyValue: boolean;
}
export function previewEntries(value: unknown): PreviewedEntries | undefined;

export function getConstructorName(value: unknown): string;

export type TypedArray =
| Uint8Array
| Uint8ClampedArray
| Uint16Array
| Uint32Array
| Int8Array
| Int16Array
| Int32Array
| BigUint64Array
| BigInt64Array
| Float32Array
| Float64Array;

export function isArrayBufferView(value: unknown): value is ArrayBufferView;
export function isArgumentsObject(value: unknown): value is IArguments;
export function isArrayBuffer(value: unknown): value is ArrayBuffer;
export function isAsyncFunction(value: unknown): value is Function;
export function isBigInt64Array(value: unknown): value is BigInt64Array;
export function isBigIntObject(value: unknown): value is BigInt;
export function isBigUint64Array(value: unknown): value is BigUint64Array;
export function isBooleanObject(value: unknown): value is Boolean;
export function isDataView(value: unknown): value is DataView;
export function isDate(value: unknown): value is Date;
export function isFloat32Array(value: unknown): value is Float32Array;
export function isFloat64Array(value: unknown): value is Float64Array;
export function isGeneratorFunction(value: unknown): value is GeneratorFunction;
export function isGeneratorObject(value: unknown): value is Generator;
export function isInt8Array(value: unknown): value is Int8Array;
export function isInt16Array(value: unknown): value is Int16Array;
export function isInt32Array(value: unknown): value is Int32Array;
export function isMap(value: unknown): value is Map<unknown, unknown>;
export function isMapIterator(value: unknown): value is IterableIterator<unknown>;
export function isModuleNamespaceObject(value: unknown): boolean;
export function isNativeError(value: unknown): value is Error;
export function isNumberObject(value: unknown): value is Number;
export function isPromise(value: unknown): value is Promise<unknown>;
export function isProxy(value: unknown): boolean;
export function isRegExp(value: unknown): value is RegExp;
export function isSet(value: unknown): value is Set<unknown>;
export function isSetIterator(value: unknown): value is IterableIterator<unknown>;
export function isSharedArrayBuffer(value: unknown): value is SharedArrayBuffer;
export function isStringObject(value: unknown): value is String;
export function isSymbolObject(value: unknown): value is Symbol;
export function isTypedArray(value: unknown): value is TypedArray;
export function isUint8Array(value: unknown): value is Uint8Array;
export function isUint8ClampedArray(value: unknown): value is Uint8ClampedArray;
export function isUint16Array(value: unknown): value is Uint16Array;
export function isUint32Array(value: unknown): value is Uint32Array;
export function isWeakMap(value: unknown): value is WeakMap<any, unknown>;
export function isWeakSet(value: unknown): value is WeakSet<any>;
export function isAnyArrayBuffer(value: unknown): value is ArrayBuffer | SharedArrayBuffer;
export function isBoxedPrimitive(value: unknown): value is Number | String | Boolean | BigInt | Symbol;
64 changes: 0 additions & 64 deletions src/workerd/api/node/inspect.c++

This file was deleted.

Loading

0 comments on commit 4daaf83

Please sign in to comment.