Merge pull request #2238 from cloudflare/jsnell/crypto-timingsafeequa…

…l-regression
cloudflare · Jun 7, 2024 · c5ebbe2 · c5ebbe2
2 parents dbc4d7f + 9767b28
commit c5ebbe2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/node/crypto.ts b/src/node/crypto.ts
@@ -10,9 +10,12 @@ import {
 
 export const getRandomValues = crypto.getRandomValues;
 export const subtle = crypto.subtle;
-export const timingSafeEqual = (subtle as any).timingSafeEqual;
 export const webcrypto = crypto;
 
+export function timingSafeEqual(a: any, b: any) {
+  return (subtle as any).timingSafeEqual(a, b);
+}
+
 import {
   DiffieHellman,
   DiffieHellmanGroup,

diff --git a/src/workerd/api/node/crypto_random-test.js b/src/workerd/api/node/crypto_random-test.js
@@ -10,6 +10,7 @@ import {
   generatePrimeSync,
   checkPrime,
   checkPrimeSync,
+  timingSafeEqual,
 } from 'node:crypto';
 
 import {
@@ -378,3 +379,9 @@ export const test = {
     }
   }
 };
+
+export const timingSafeEqualTest = {
+  test() {
+    timingSafeEqual(new Uint8Array(1), new Uint8Array(1));
+  }
+};