-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 BUG: wrangler errors in GitHub Actions "Received signal #11: Segmentation fault" #1075
Labels
bug
Something isn't working
Comments
Hey! 👋 I'm guessing this is the same issue as cloudflare/miniflare#651. We've reported this to the runtime team. 👍 |
ohodson
added a commit
that referenced
this issue
Aug 29, 2023
Fixes a race between initializing the InspectorService::isolates field on the inspector service thread and Server::InspectorServiceIsolateRegistrar::registerIsolate inserting an isolate into the InspectorSerivce::isolates field on a worker thread. This change ensures that the InspectorService instance is initialized before worker threads can start registering isolates. Test: manual check repro steps in cloudflare/miniflare#651 no longer cause crashes. Bug: #1075 Bug: cloudflare/miniflare#651 Bug: EW-7716
ohodson
added a commit
that referenced
this issue
Aug 29, 2023
Fixes a race between initializing the InspectorService::isolates field on the inspector service thread and Server::InspectorServiceIsolateRegistrar::registerIsolate inserting an isolate into the InspectorSerivce::isolates field on a worker thread. This change ensures that the InspectorService instance is initialized before worker threads can start registering isolates. Test: manual check repro steps in cloudflare/miniflare#651 no longer repro. Bug: #1075 Bug: cloudflare/miniflare#651 Bug: EW-7716
ohodson
added a commit
that referenced
this issue
Aug 30, 2023
Fixes a race between initializing the InspectorService::isolates field on the inspector service thread and Server::InspectorServiceIsolateRegistrar::registerIsolate inserting an isolate into the InspectorSerivce::isolates field on a worker thread. This change ensures that the InspectorService instance is initialized before worker threads can start registering isolates. Test: manual check repro steps in cloudflare/miniflare#651 no longer repro. Bug: #1075 Bug: cloudflare/miniflare#651 Bug: EW-7716
ohodson
added a commit
that referenced
this issue
Aug 30, 2023
Fixes a race between initializing the InspectorService::isolates field on the inspector service thread and Server::InspectorServiceIsolateRegistrar::registerIsolate inserting an isolate into the InspectorSerivce::isolates field on a worker thread. This change ensures that the InspectorService instance is initialized before worker threads can start registering isolates. Test: manual check repro steps in cloudflare/miniflare#651 no longer repro. Bug: #1075 Bug: cloudflare/miniflare#651 Bug: EW-7716
I am no longer seeing the error after upgrading wrangler to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Which Cloudflare product(s) does this pertain to?
Wrangler core
What version(s) of the tool(s) are you using?
3.6.0 [Wrangler]
What version of Node are you using?
18.17.1
What operating system are you using?
Ubuntu 22.04
Describe the Bug
Wrangler versions 3.5.0-3.6.0 errors in GitHub Actions using the images
ubuntu-20.04
andubuntu-22.04
:Related to cloudflare/workers-sdk#3631
Please provide a link to a minimal reproduction
encrypit/encrypit#181
Please provide any relevant error logs
The text was updated successfully, but these errors were encountered: