Fix exception message in Socket::handleProxyStatus #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that I can handle initial connection errors on connections that were established without using HTTP connect.
This was broken by the recent switch to use JSG_KJ_EXCEPTION.
a-robinson
force-pushed
the
arobinson/socket-handle-proxy-status-fix
branch
from
fc4e91a
to
271cb06
Compare
jasnell
approved these changes
Aug 9, 2023
dom96
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by the recent switch to use JSG_KJ_EXCEPTION.
This PR re-applies the recently reverted #975 and applies a fix on top. The commits should preferably be squashed when merging.