SQL: increase EXPR_DEPTH from 20 -> 100 #1279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the maximum expression depth to 100 as an intermediate measure, accepting that it may not unblock every user.
Background: We're seeing developers (particularly those using ORMs) run into limitations when running queries against D1. It is not clear from an EQP (EXPLAIN QUERY PLAN) output what the expression depth of a query is, which makes it challenging to set this to a value that works for users without being unnecessarily high — the deeper the expression depth the more likely the query to just run into other limits.
For context:
Fixes #4094