Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: increase EXPR_DEPTH from 20 -> 100 #1279

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

elithrar
Copy link
Contributor

@elithrar elithrar commented Oct 5, 2023

This PR sets the maximum expression depth to 100 as an intermediate measure, accepting that it may not unblock every user.

Background: We're seeing developers (particularly those using ORMs) run into limitations when running queries against D1. It is not clear from an EQP (EXPLAIN QUERY PLAN) output what the expression depth of a query is, which makes it challenging to set this to a value that works for users without being unnecessarily high — the deeper the expression depth the more likely the query to just run into other limits.

For context:

Fixes #4094

@elithrar elithrar changed the title SRS: increase EXPR_DEPTH from 20 -> 100 SQL: increase EXPR_DEPTH from 20 -> 100 Oct 10, 2023
@byule byule merged commit ea8b70b into cloudflare:main Oct 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: D1 max expression tree depth example and discussion
3 participants