Vectorize: optionally return metadata for a vector query #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netgusto
approved these changes
Oct 16, 2023
|
Nice! Can we make sure to prep a docs PR in advance of this going out? (https://developers.cloudflare.com/workers/configuration/compatibility-dates/#compatibility-flags) — thanks! |
Gotcha 👍 |
jasnell
approved these changes
Oct 17, 2023
|
Marking this as "needs-internal-pr" just to make sure there is an internal CI run done before this lands. Once/if the internal PR and CI is done and everything looks good, the label can be removed and this can be landed. |
Adds compatibility flag support to the wrapped Vectorize binding.
jasnell
approved these changes
Oct 31, 2023
|
@mrbbot ... looks like this needs a sign off from someone on the wrangler team since it touches one of the CODEOWNERs rules. |
mrbbot
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a breaking change to the Vectorize query API that changes both the request and response formats.
This is managed by a new compatibility flag which is forwarded to the implementation to derive the correct format.