Bootstrap vscode dev container #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 🙌 🙌 |
ohodson
reviewed
Oct 11, 2023
| RUN curl -fSsL -o /usr/local/bin/buildifier https://github.com/bazelbuild/buildtools/releases/download/${BUILDIFER_VERSION}/buildifier-linux-amd64 \ | ||
| && echo "${BUILDIFER_DOWNLOAD_SHA} /usr/local/bin/buildifier" | sha256sum --check \ | ||
| && chmod 0755 /usr/local/bin/buildifier | ||
|
|
ohodson
approved these changes
Oct 11, 2023
ohodson
approved these changes
Oct 11, 2023
jasnell
reviewed
Oct 15, 2023
Co-authored-by: James M Snell <jasnell@gmail.com>
jasnell
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a vscode devcontainer for workerd, installing all needed dependencies and doing ide setup for developers.
On opening the project in vscode, users will see this modal. Clicking the
Reopen in Containerwill launch the dev containerThis doesn't make any changes to existing setups, just another tool in the belt 🙂