-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix websocket auto-response message races #1309
Conversation
65863fb
to
8a5c005
Compare
813a381
to
41f4b54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as it passes internal CI! Thanks for your work.
41f4b54
to
efc8ac0
Compare
This PR fixes racing issues between regular websocket messages and auto-responses.
efc8ac0
to
c08ad41
Compare
Thank you, @bcaimano and @MellowYarker for the very fast review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments but they're mostly for cleanup/maintainability. PR can be merged if you've got other stuff to focus on, thanks for fixing this!
c08ad41
to
6053b8e
Compare
Thanks for the cleanup! |
Co-authored-by: James M Snell <jsnell@cloudflare.com>
This PR fixes racing issues between regular websocket messages and auto-responses.
The initial version of this PR held a jsg::Ref<> for a long time, which could cause occasional segfaults. This new version fixes that segfault.