Log warnings directly to stderr locally
#1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohodson
reviewed
Nov 28, 2023
| KJ_LOG(INFO, "console warning", description); | ||
| } else { | ||
| fprintf(stderr, "%s\n", description.cStr()); | ||
| fflush(stderr); |
There was a problem hiding this comment.
stderr is unbuffered, fflush probably isn't helping here.
There was a problem hiding this comment.
I thought that initially too, but when spawning workerd from Node and piping the output to a stream, it looks like you need explicit flushes. See #1343.
There was a problem hiding this comment.
Yeah I thought it was buffered too, that's surprising. An alternative might be to use setvbuf()/setlinebuf() to enable line buffering for stderr, but that would affect it outside of this scope too.
ohodson
approved these changes
Nov 28, 2023
jasnell
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋 With #1294,
console.log()s are now logged directly to stdio when running locally. This means Wrangler no longer uses the V8 inspector to receive log messages. Unfortunately, this means we're were missing out on some warnings fromworkerd. This change logs those warnings directly tostderrtoo if we're running locally.Ref: cloudflare/workers-sdk#4512