Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist the actorId for ActorSqliteHooks #1474

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Persist the actorId for ActorSqliteHooks #1474

merged 1 commit into from
Dec 5, 2023

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Dec 5, 2023

An actor setting an alarm would start to fail after hibernation due to the ActorKey pointing to a kj::StringPtr that would be freed.

Fixes: #1386

@jasnell jasnell requested review from a team as code owners December 5, 2023 17:57
@jasnell jasnell requested a review from vickykont December 5, 2023 17:57
MellowYarker
MellowYarker approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@MellowYarker MellowYarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@jasnell jasnell mentioned this pull request Dec 5, 2023
Closed
@jasnell jasnell merged commit af2996a into main Dec 5, 2023
11 checks passed
@fhanau fhanau deleted the jsnell/persist-actor-id-for-actorsqlitehooks branch December 6, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-mp justin-mp justin-mp approved these changes

@MellowYarker MellowYarker MellowYarker approved these changes

@xortive xortive Awaiting requested review from xortive

@kentonv kentonv Awaiting requested review from kentonv

@vickykont vickykont Awaiting requested review from vickykont vickykont is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report — Runtime APIs: alarm-scheduler fails for inscrutable reason
3 participants
@jasnell @justin-mp @MellowYarker