2023-12-06 Update Rust crates, brotli #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also need to explicitly add zlib, this used to be pulled in via rules_rust.
fhanau
force-pushed
the
felix/2023-12-06-rust-update
branch
from
3f49704 to
fa1903f
Compare
This is only a partial update – the upstream version hides the RSA struct, so we'll need to make some crypto changes to accommodate it in the future. Changes include performance impovements to *25519 algorithms, which also reduce the binary size slightly as more compact lookup tables are used.
dom96
approved these changes
Dec 7, 2023
jasnell
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also requires explicitly adding zlib as a dependency, which used to be pulled in via rules_rust.