-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill out more of the node:util implementation #1804
Conversation
6221733
to
b9bc004
Compare
Code looks good to me. Some observations:
|
I'll see about adding some tests. |
77f0f1d
to
58e1be2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests LGTM, having more would be nice to have but the attack surface of these functions is small so not required. Based on the number of commits consider combining some of them/using squash-merge.
Handful of additional
node:util
APIs