Python perf: Don't report undefined symbols #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
approved these changes
Mar 20, 2024
hoodmane
force-pushed
the
hoodmane/dont-report-undefined-symbols
branch
2 times, most recently
from
00ca09d to
775d543
Compare
In flame graphs this single call frame takes up a lot of loading time. It also is not necessary except for debugging purposes. This gets rid of it.
hoodmane
force-pushed
the
hoodmane/dont-report-undefined-symbols
branch
from
775d543 to
6187efc
Compare
|
I think this broke local dev, I'll make a PR to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In flame graphs this single call frame takes up a lot of loading time. It also is not necessary except for debugging purposes. This gets rid of it.