Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused waitUntilTasks fields #2224

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Remove unused waitUntilTasks fields #2224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/workerd/api/hibernatable-web-socket.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,13 @@ HibernatableWebSocketCustomEventImpl::HibernatableWebSocketCustomEventImpl(
kj::TaskSet& waitUntilTasks,
kj::Own<HibernationReader> params,
kj::Maybe<Worker::Actor::HibernationManager&> manager)
: typeId(typeId), waitUntilTasks(waitUntilTasks), params(kj::mv(params)) {}
: typeId(typeId), params(kj::mv(params)) {}
HibernatableWebSocketCustomEventImpl::HibernatableWebSocketCustomEventImpl(
uint16_t typeId,
kj::TaskSet& waitUntilTasks,
HibernatableSocketParams params,
Worker::Actor::HibernationManager& manager)
: typeId(typeId), waitUntilTasks(waitUntilTasks), params(kj::mv(params)), manager(manager) {}
: typeId(typeId), params(kj::mv(params)), manager(manager) {}

HibernatableSocketParams HibernatableWebSocketCustomEventImpl::consumeParams() {
KJ_IF_SOME(p, params.tryGet<kj::Own<HibernationReader>>()) {
Expand Down
1 change: 0 additions & 1 deletion src/workerd/api/hibernatable-web-socket.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ class HibernatableWebSocketCustomEventImpl final: public WorkerInterface::Custom
HibernatableSocketParams consumeParams();

uint16_t typeId;
kj::TaskSet& waitUntilTasks;
kj::OneOf<HibernatableSocketParams, kj::Own<HibernationReader>> params;
kj::Maybe<uint32_t> timeoutMs;
kj::Maybe<Worker::Actor::HibernationManager&> manager;
Expand Down
3 changes: 1 addition & 2 deletions src/workerd/api/trace.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ class TraceCustomEventImpl final: public WorkerInterface::CustomEvent {
public:
TraceCustomEventImpl(
uint16_t typeId, kj::TaskSet& waitUntilTasks, kj::Array<kj::Own<Trace>> traces)
: typeId(typeId), waitUntilTasks(waitUntilTasks), traces(kj::mv(traces)) {}
: typeId(typeId), traces(kj::mv(traces)) {}

kj::Promise<Result> run(
kj::Own<IoContext::IncomingRequest> incomingRequest,
Expand All @@ -608,7 +608,6 @@ class TraceCustomEventImpl final: public WorkerInterface::CustomEvent {

private:
uint16_t typeId;
kj::TaskSet& waitUntilTasks;
kj::Array<kj::Own<workerd::Trace>> traces;
};

Expand Down
Loading