Commits on Jun 6, 2024

1. Add V8 cross-thread profiling patches …

   V8's profiler does not expect isolates to be locked from different threads. Pull request #710 moved inspector protocol handling to a separate thread, meaning profiling was started and stopped on the inspector thread, not the Worker's request connection thread. If I remember right, the result of this is that the profiler ends up sampling the inspector thread, which doesn't normally run JavaScript, and causes a bunch of "(program)" placeholder spans to show up in the profile.
   
   We previously discovered this issue with our internal runtime, which has always been heavily multi-threaded, and patched around the problem. This commit copies the two relevant patches from our internal repo.
   
   Fixes #1754.

   

   harrishancock committed Jun 6, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for f988174
   • Browse repository at this point

   Copy the full SHA

   f988174 View commit details

   Browse the repository at this point in the history