Redoing "#2073: Update Request to support cache option" with compat flags #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Request object to support specifying a cache mode per the standard. Only `undefined`, `'no-store'` and `'no-cache'` may be specified, and the fetch implementation specifically does not implement the semantics for either `'no-store'` or `'no-cache'` yet. This just lays the ground work for the additional changes.
Co-authored-by: Dominik Picheta <dominik@cloudflare.com>
Co-authored-by: Dominik Picheta <dominik@cloudflare.com>
AdityaAtulTewari
force-pushed
the
jsnell/http-request-cache-part1
branch
from
9ff4198
to
fa9c5a0
Compare
jasnell
reviewed
Jul 17, 2024
jasnell
reviewed
Jul 17, 2024
jasnell
reviewed
Jul 17, 2024
jasnell
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RM-18292
Updates the Request object to support specifying a cache mode per the standard. Only undefined, 'no-store' and 'no-cache' may be specified, and the fetch implementation specifically does not implement the semantics for either 'no-store' or 'no-cache' yet.
Also adds the compatibility flag for
cacheHeaderEnabled. This just lays the ground work for the additional changes.The next step is to start adding the support for adding the appropriate header fields in the fetch implementation behind an autogate.