types: Fix D1 run() type #2422
Merged
types: Fix D1 run() type #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is out of sync with prod, which is does accept a type parameter and returns a `D1Result`
4 tasks
penalosa
approved these changes
Jul 22, 2024
CarmenPopoviciu
approved these changes
Jul 22, 2024
anonrig
approved these changes
Jul 22, 2024
|
You might need to revert 79308ef#diff-82819dcdc1d72711b0598dd31c4f68ee247dd36228ab8a53405f9e6be4600b13 to get tests passing CC @geelen |
mikea
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is out of sync with prod, which is does accept a type parameter and returns a
D1Resultcc @vy-ton @geelen