Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize cache control headers, repeat of #2074 for cache: no-store. #2425

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Initialize cache control headers, repeat of #2074 for cache: no-store. #2425

merged 1 commit into from
Sep 20, 2024

Conversation

AdityaAtulTewari
Copy link
Contributor

@AdityaAtulTewari AdityaAtulTewari commented Jul 22, 2024 •
edited
Loading

No description provided.

@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch from 48afb76 to dd748ad Compare July 22, 2024 22:41
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch from dd748ad to c4f5880 Compare August 6, 2024 16:51
@AdityaAtulTewari AdityaAtulTewari changed the base branch from main to AdityaAtulTewari/http-request-cache-part1 August 6, 2024 16:54
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part1 branch from 4af033d to 9371ec7 Compare August 7, 2024 15:53
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch 5 times, most recently from 6c71226 to 073ec7e Compare August 9, 2024 19:01
@AdityaAtulTewari AdityaAtulTewari marked this pull request as ready for review August 9, 2024 19:05
@AdityaAtulTewari AdityaAtulTewari requested review from a team as code owners August 9, 2024 19:05
@AdityaAtulTewari AdityaAtulTewari requested review from a-robinson and hoodmane and removed request for a team August 9, 2024 19:05
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch from 073ec7e to fc68be9 Compare August 10, 2024 05:59
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part1 branch from 9371ec7 to 8852ad7 Compare August 10, 2024 06:36
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch 3 times, most recently from 60b2a44 to 77fdc91 Compare August 12, 2024 21:49
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part1 branch 3 times, most recently from e2f2390 to c147312 Compare August 13, 2024 02:46
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch from 77fdc91 to a496097 Compare August 13, 2024 03:35
hoodmane
hoodmane reviewed Aug 14, 2024
View reviewed changes
src/workerd/api/http-test-ts.ts Outdated Show resolved Hide resolved
src/workerd/server/server-test.c++ Outdated Show resolved Hide resolved
src/workerd/api/http.c++ Outdated Show resolved Hide resolved
src/workerd/api/http.c++ Show resolved Hide resolved
src/workerd/api/http.c++ Outdated Show resolved Hide resolved
src/workerd/api/http.c++ Outdated Show resolved Hide resolved
src/workerd/api/http-test.js Outdated Show resolved Hide resolved
src/workerd/api/http-test.js Outdated Show resolved Hide resolved
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch from a496097 to 7d77553 Compare August 19, 2024 11:18
Base automatically changed from AdityaAtulTewari/http-request-cache-part1 to main August 30, 2024 21:56
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch 3 times, most recently from ec6d7df to bb0151a Compare September 3, 2024 15:49
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch from bb0151a to e51a319 Compare September 3, 2024 16:02
hoodmane
hoodmane approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch from e51a319 to 6129b4f Compare September 4, 2024 13:29
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch from 6129b4f to f174a78 Compare September 10, 2024 18:17
kentonv
kentonv reviewed Sep 12, 2024
View reviewed changes
src/workerd/api/http.c++ Outdated Show resolved Hide resolved
@kentonv
Copy link
Member

kentonv commented Sep 12, 2024

Since everything is gated behind cacheMode which isn't settable without the experimental compat flag, this looks fine from a "won't break anyone" perspective. I think the autogate can be removed as the compat flag already gates the new logic just fine. Rolling out an autogate would be needless additional work.

@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch 3 times, most recently from 011f7c0 to 01e45d0 Compare September 13, 2024 13:33
@AdityaAtulTewari AdityaAtulTewari changed the title Add http cache mode autogate, initialize cache control headers, repea… Initialize cache control headers, repeat of #2074 for cache: no-store. Sep 13, 2024
@AdityaAtulTewari
Copy link
Contributor Author

That makes sense and the change has been update to reflect not needing an autogate.

jasnell
jasnell reviewed Sep 18, 2024
View reviewed changes
src/workerd/api/http.c++ Outdated Show resolved Hide resolved
jasnell
jasnell reviewed Sep 18, 2024
View reviewed changes
src/workerd/api/http.c++ Outdated Show resolved Hide resolved
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch from 01e45d0 to 9d578fb Compare September 19, 2024 21:42
@AdityaAtulTewari AdityaAtulTewari force-pushed the AdityaAtulTewari/http-request-cache-part2 branch from 9d578fb to e04c649 Compare September 20, 2024 19:07
@AdityaAtulTewari AdityaAtulTewari merged commit 6cead80 into main Sep 20, 2024
14 checks passed
@AdityaAtulTewari AdityaAtulTewari deleted the AdityaAtulTewari/http-request-cache-part2 branch September 20, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoodmane hoodmane hoodmane approved these changes

@jasnell jasnell jasnell approved these changes

@a-robinson a-robinson Awaiting requested review from a-robinson a-robinson is a code owner automatically assigned from cloudflare/workers-runtime-1

@kentonv kentonv Awaiting requested review from kentonv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdityaAtulTewari @kentonv @jasnell @hoodmane