Http Request Cache Part 1 #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaAtulTewari
force-pushed
the
AdityaAtulTewari/http-request-cache-part1
branch
from
905efd7
to
975063b
Compare
AdityaAtulTewari
changed the base branch from
main
to
AdityaAtulTewari/claim-cache-option-enabled-compat-flag
Base automatically changed from
AdityaAtulTewari/claim-cache-option-enabled-compat-flag
to
main
July 24, 2024 18:16
kentonv
reviewed
Jul 24, 2024
AdityaAtulTewari
force-pushed
the
AdityaAtulTewari/http-request-cache-part1
branch
from
3afdcc0
to
0a12f2c
Compare
kentonv
reviewed
Jul 29, 2024
AdityaAtulTewari
force-pushed
the
AdityaAtulTewari/http-request-cache-part1
branch
from
0a12f2c
to
fff5de3
Compare
jasnell
reviewed
Jul 31, 2024
jasnell
reviewed
Jul 31, 2024
jasnell
reviewed
Jul 31, 2024
jasnell
reviewed
Jul 31, 2024
jasnell
reviewed
Jul 31, 2024
AdityaAtulTewari
force-pushed
the
AdityaAtulTewari/http-request-cache-part1
branch
3 times, most recently
from
68a2c75
to
1d13ab0
Compare
jasnell
reviewed
Aug 1, 2024
jasnell
reviewed
Aug 1, 2024
AdityaAtulTewari
force-pushed
the
AdityaAtulTewari/http-request-cache-part1
branch
2 times, most recently
from
5aa3639
to
bf88e9e
Compare
Based on the results of this PR: #2480 the typescript results are no different. Do we want to add tests for every frontend? |
AdityaAtulTewari
force-pushed
the
AdityaAtulTewari/http-request-cache-part1
branch
from
78f8add
to
4af033d
Compare
AdityaAtulTewari
force-pushed
the
AdityaAtulTewari/http-request-cache-part1
branch
from
8852ad7
to
330f6cc
Compare
AdityaAtulTewari
force-pushed
the
AdityaAtulTewari/http-request-cache-part1
branch
from
330f6cc
to
e2f2390
Compare
AdityaAtulTewari
force-pushed
the
AdityaAtulTewari/http-request-cache-part1
branch
from
e2f2390
to
c147312
Compare
dario-piotrowicz
approved these changes
Aug 13, 2024
6 tasks
|
In the non-experimental types files we get this addition: So, the comment plus the I think this quite ugly... but maybe acceptable? 🤷 Ideally I think we should not add anything in those files, but I have no idea about the technical limitations and whatnot, if this is the best we can do I think it's fine |
AdityaAtulTewari
force-pushed
the
AdityaAtulTewari/http-request-cache-part1
branch
from
fe835ed
to
a293314
Compare
dario-piotrowicz
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Looks perfect! thanks for the ts improvement @AdityaAtulTewari! 🫶
AdityaAtulTewari
force-pushed
the
AdityaAtulTewari/http-request-cache-part1
branch
from
62a34b9
to
30185d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RM-18292
refs #698 and cloudflare/workers-sdk#2514
Follow-up to reintroduce the behavior that was reverted in #2432
Updates the Request object to support specifying a cache mode per the standard. Only undefined, 'no-store' and 'no-cache' may be specified, and the fetch implementation specifically does not implement the semantics for either 'no-store' or 'no-cache' yet.
Also adds the compatibility flag for cacheHeaderEnabled. This just lays the ground work for the additional changes.
The next step is to start adding the support for adding the appropriate header fields in the fetch implementation behind an autogate