Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor bazel test setup #2495

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

garrettgu10
Copy link
Collaborator

@garrettgu10 garrettgu10 commented Aug 7, 2024

Merge target is load-pyodide-from-http since this change depends on the pyodide bundle disk cache being accepted by workerd.

Changes:

  • introduces new py_wd_test function that automatically includes the pyodide bundle disk cache arguments
  • deletes langchain wd_test

@garrettgu10 garrettgu10 requested review from a team as code owners August 7, 2024 19:15
@garrettgu10 garrettgu10 requested review from mikea, AdityaAtulTewari and hoodmane and removed request for a team, mikea and AdityaAtulTewari August 7, 2024 19:15
Copy link
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @garrettgu10!

hoodmane

This comment was marked as duplicate.

@garrettgu10 garrettgu10 merged commit 826743f into ggu/load-pyodide-from-http Aug 8, 2024
9 checks passed
@garrettgu10 garrettgu10 deleted the ggu/refactor-bazel-test branch August 8, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants