node:zlib implem: Expose zlib.constants

[npaun]

No description provided.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[npaun]

I have read the CLA Document and I hereby sign the CLA

[npaun]

recheck

[jasnell]

nit: if constants are added later it would be easy for this list to get out of date. I wonder if it would make sense to have the test fail if there are any unexpected constants in the constants object. You can check for that fairly easily by grabbing the Object.keys() and removing each item that is explicitly tested here then throwing if there are any left over at the end.

[npaun]

Are you suggesting to test for this list of keys, and not check the values, or am I misunderstanding the suggestion?

[jasnell]

For for the list of keys and the values, but throw if there are additional keys in constants not tested for explicitly.

[npaun]

Thanks for the suggestions, guys. It should be ready to go now.

[jasnell]

If you would, rebase this PR on main again and let's give the internal PR CI run another go.

[npaun]

@jasnell Done. However I still didn't sort out the zlib version inconsistency so I think it'll fail again.

[jasnell]

That's fine, I just noticed that the internal streams.ew-test failed and it's likely because of the commit that got reverted this morning. The rebase at least helps to rule that out