More incremental work on new module registry impl #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
commented
Aug 17, 2024
jasnell
force-pushed
the
jsnell/moar-new-module-registry-fun
branch
2 times, most recently
from
20b3891
to
825741d
Compare
anonrig
approved these changes
Aug 24, 2024
jasnell
force-pushed
the
jsnell/moar-new-module-registry-fun
branch
from
825741d
to
68e18d6
Compare
Adds in the part about ensuring ESM evaluation occurs outside of the IoContext if there is one.
This bit of code uses the node.js formatLog API to create formatted output for things like console.log... it needs to be able to use either module registry implementation.
jasnell
force-pushed
the
jsnell/moar-new-module-registry-fun
branch
from
68e18d6
to
0beb18d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in the part about ensuring ESM evaluation occurs outside of the IoContext if there is one.
Some context for newcomers: I've been slowly working on a new implementation of the module registry in workerd. This is a continuation of that work. Here I implement the bits of the code necessary to ensure that the module is evaluated outside of the IoContext if there is one.
This code currently is not used in production.